Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor typings for readability #168

Merged
merged 3 commits into from Sep 7, 2019
Merged

Conversation

@phryneas
Copy link
Collaborator

phryneas commented Aug 3, 2019

This should make the typings more readable for someone just diving into this lib's typings, as we already discussed on twitter :)

@netlify

This comment has been minimized.

Copy link

netlify bot commented Aug 3, 2019

Deploy preview for redux-starter-kit-docs ready!

Built with commit 93509ee

https://deploy-preview-168--redux-starter-kit-docs.netlify.com


export type ActionCreatorWithPayload<P, T extends string = string> =
WithTypeProperty<T, <PT extends P>(payload: PT) => PayloadAction<PT, T>>;

/**
* An action creator that produces actions with a `payload` attribute.
*/
export type PayloadActionCreator<
P = any,

This comment has been minimized.

Copy link
@phryneas

phryneas Aug 3, 2019

Author Collaborator

I could go and rename P to payload, T to Type and PA to PrepareActionFn here, but I'm not really sure if it makes things better or worse in the usages of these below.
Do you have an opinion there?

@phryneas

This comment has been minimized.

Copy link
Collaborator Author

phryneas commented Aug 27, 2019

@markerikson what's your status on this? From my side this would be ready if you don't have any additional comments.

@markerikson

This comment has been minimized.

Copy link
Collaborator

markerikson commented Aug 27, 2019

I'm focusing on trying to finish the tutorials atm. Once I'm done with those, I plan to swing around and start pushing issues and PRs towards 1.0.

@phryneas

This comment has been minimized.

Copy link
Collaborator Author

phryneas commented Aug 27, 2019

Okay :) Just wanted to make sure this didn't get buried ^^

@markerikson

This comment has been minimized.

Copy link
Collaborator

markerikson commented Sep 7, 2019

Sure, let's do this.

@markerikson markerikson merged commit 85923d4 into reduxjs:master Sep 7, 2019
6 checks passed
6 checks passed
Header rules - redux-starter-kit-docs No header rules processed
Details
Pages changed - redux-starter-kit-docs All files already uploaded
Details
Redirect rules - redux-starter-kit-docs No redirect rules processed
Details
Mixed content - redux-starter-kit-docs No mixed content detected
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/redux-starter-kit-docs/deploy-preview Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.