Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add middleware for detecting mutations and non-serializable values #63

Merged
merged 10 commits into from Dec 24, 2018

Conversation

@markerikson
Copy link
Collaborator

markerikson commented Dec 24, 2018

Thus far, our "default middleware" has just been redux-thunk.

I've added a dependency on https://github.com/leoasis/redux-immutable-state-invariant , which throws errors if it detects state mutations.

I've also cobbled together a middleware that inspects both actions and state for non-serializable values, and prints console errors if it finds any.

I've added both of them to the default middleware setup, in dev only.

@netlify

This comment has been minimized.

Copy link

netlify bot commented Dec 24, 2018

Deploy preview for redux-starter-kit-docs ready!

Built with commit 8387e2c

https://deploy-preview-63--redux-starter-kit-docs.netlify.com

@markerikson markerikson merged commit a4b621d into master Dec 24, 2018
5 checks passed
5 checks passed
Header rules - redux-starter-kit-docs No header rules processed
Details
Pages changed - redux-starter-kit-docs All files already uploaded
Details
Redirect rules - redux-starter-kit-docs No redirect rules processed
Details
Mixed content - redux-starter-kit-docs No mixed content detected
Details
netlify/redux-starter-kit-docs/deploy-preview Deploy preview ready!
Details
@markerikson markerikson deleted the devtool-middleware branch Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.