Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd middleware for detecting mutations and non-serializable values #63
Conversation
This comment has been minimized.
This comment has been minimized.
netlify
bot
commented
Dec 24, 2018
Deploy preview for redux-starter-kit-docs ready! Built with commit 8387e2c https://deploy-preview-63--redux-starter-kit-docs.netlify.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
markerikson commentedDec 24, 2018
Thus far, our "default middleware" has just been
redux-thunk
.I've added a dependency on https://github.com/leoasis/redux-immutable-state-invariant , which throws errors if it detects state mutations.
I've also cobbled together a middleware that inspects both actions and state for non-serializable values, and prints console errors if it finds any.
I've added both of them to the default middleware setup, in dev only.