Rename Actions to "Records"? #377

Closed
wmertens opened this Issue Jul 31, 2015 · 4 comments

Comments

4 participants
@wmertens
Contributor

wmertens commented Jul 31, 2015

I love the rename of Stores to Reducers, it really changes how you think about the code, and I noticed that there is some confusion between actual actions taken and the record of their results as Action objects.

Action objects are really only news items and they can be recorded by the reducers but they don't perform any work, that was already done. (started a request, got data from server etc).

Therefore I think it would help our mental model if they are renamed to Records (or NewsItems, Events, ...?).

Then ActionCreators can remain the "actions" they are colloquially (or even be renamed to just Actions).

It would look like this:

redux flow

@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Jul 31, 2015

Collaborator

We've been bikeshedding on this for quite a while, and from the conversations I was in, I didn't find any better word than “actions”. A new term has to be significantly better to justify inventing yet another terminology.

Redux names comes from “Flux with reducers” and it makes sense for me to keep the Flux terminology, at least to aid the beginners.

In the new docs, we are calling them “actions” and “async actions”. I tried calling them “intents” but that just complicates docs because there is clearly a new term, but their role in Redux is supplementary rather than critical.

Collaborator

gaearon commented Jul 31, 2015

We've been bikeshedding on this for quite a while, and from the conversations I was in, I didn't find any better word than “actions”. A new term has to be significantly better to justify inventing yet another terminology.

Redux names comes from “Flux with reducers” and it makes sense for me to keep the Flux terminology, at least to aid the beginners.

In the new docs, we are calling them “actions” and “async actions”. I tried calling them “intents” but that just complicates docs because there is clearly a new term, but their role in Redux is supplementary rather than critical.

@wmertens

This comment has been minimized.

Show comment
Hide comment
@wmertens

wmertens Aug 1, 2015

Contributor

Another good name I heard was Fact. Just recording for posterity.

Contributor

wmertens commented Aug 1, 2015

Another good name I heard was Fact. Just recording for posterity.

@adri

This comment has been minimized.

Show comment
Hide comment
@adri

adri Aug 4, 2015

Events is a common term for facts in the event sourcing world.

adri commented Aug 4, 2015

Events is a common term for facts in the event sourcing world.

@edge

This comment has been minimized.

Show comment
Hide comment
@edge

edge Aug 5, 2015

Contributor

What about Memo? Since that's what actions really kind of are. Just like in real life, Memos are read and acted upon by the Reducers (workers), and may be intercepted or modified on the way by Middleware (higher-ups).

Additionally, I think Record might be really confusing for Immutable users.

Contributor

edge commented Aug 5, 2015

What about Memo? Since that's what actions really kind of are. Just like in real life, Memos are read and acted upon by the Reducers (workers), and may be intercepted or modified on the way by Middleware (higher-ups).

Additionally, I think Record might be really confusing for Immutable users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment