New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emphasize defining selectors alongside reducers in examples #839

Closed
gaearon opened this Issue Oct 3, 2015 · 2 comments

Comments

2 participants
@gaearon
Contributor

gaearon commented Oct 3, 2015

We should use selectors in our examples like we do here: voronianski/flux-comparison#64.

Otherwise people are having a hard time how to change the state shape safely because they have to update their mapStateToProps all over the project.

@gaearon gaearon added the examples label Oct 3, 2015

@barockok

This comment has been minimized.

Show comment
Hide comment
@barockok

barockok Nov 7, 2015

@gaearon should we start use reselect ?

barockok commented Nov 7, 2015

@gaearon should we start use reselect ?

@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Nov 7, 2015

Contributor

Not necessarily. I mostly mean the idea of exporting selector functions from reducer. They don't have to be powered by reselect (although it's a nice optimization).

In fact we already moved shopping cart example from Flux comparison into Redux repo, so this issue can be closed, as it adequately demonstrates the technique.

Contributor

gaearon commented Nov 7, 2015

Not necessarily. I mostly mean the idea of exporting selector functions from reducer. They don't have to be powered by reselect (although it's a nice optimization).

In fact we already moved shopping cart example from Flux comparison into Redux repo, so this issue can be closed, as it adequately demonstrates the technique.

@gaearon gaearon closed this Nov 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment