New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded code #1640

Closed
wants to merge 1 commit into
base: master
from

Conversation

2 participants
@stevemao
Contributor

stevemao commented Apr 20, 2016

console.error can print the call site. Even if console.error didn't or doesn't exist, the try...catch block cannot print the call site. It does nothing here.

Remove unneeded code
`console.error` can print the call site. Even if `console.error` didn't or doesn't exist, the `try...catch` block cannot print the call site. It does nothing here.
@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Apr 20, 2016

Collaborator

It’s not for printing, it’s for “break on all exceptions” that would pause the execution at this line.

Collaborator

gaearon commented Apr 20, 2016

It’s not for printing, it’s for “break on all exceptions” that would pause the execution at this line.

@stevemao

This comment has been minimized.

Show comment
Hide comment
@stevemao

stevemao Apr 20, 2016

Contributor

Very interesting technique. Thanks :)

Contributor

stevemao commented Apr 20, 2016

Very interesting technique. Thanks :)

@stevemao stevemao closed this Apr 20, 2016

@stevemao

This comment has been minimized.

Show comment
Hide comment
@stevemao

stevemao Apr 20, 2016

Contributor

Although I think the comment is not very clear. It should be what you just said :)

Contributor

stevemao commented Apr 20, 2016

Although I think the comment is not very clear. It should be what you just said :)

@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Apr 20, 2016

Collaborator

Good point. Feel free to edit!

Collaborator

gaearon commented Apr 20, 2016

Good point. Feel free to edit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment