New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch out non-ASCII quotes for ASCII versions. #1874

Merged
merged 1 commit into from Aug 1, 2016

Conversation

3 participants
@timdorr
Member

timdorr commented Jul 31, 2016

I was going to just commit this on master, but that would probably bust every PR currently in play that touches the docs 馃槃

But the idea here is to use standard ASCII quotes everywhere. They smart quotes or angled quotes are causing some display issues in places (namely on GH Pages).

@markerikson

This comment has been minimized.

Show comment
Hide comment
@markerikson

markerikson Jul 31, 2016

Contributor

Yeah, uh... Dan's kinda picky on that one :) I never managed to properly get them entered or displayed while working on the FAQ page, but Dan really seems to want that bit of typography, and he took the time to edit them in once I published my initial text.

Contributor

markerikson commented Jul 31, 2016

Yeah, uh... Dan's kinda picky on that one :) I never managed to properly get them entered or displayed while working on the FAQ page, but Dan really seems to want that bit of typography, and he took the time to edit them in once I published my initial text.

@timdorr

This comment has been minimized.

Show comment
Hide comment
@timdorr

timdorr Jul 31, 2016

Member

@gaearon Is this an issue? ASCII quotes are more accessible (namely when screenreaders vocalize the HTML character code as literal text instead of an ignored quote) and generally have less problems with tooling.

Member

timdorr commented Jul 31, 2016

@gaearon Is this an issue? ASCII quotes are more accessible (namely when screenreaders vocalize the HTML character code as literal text instead of an ignored quote) and generally have less problems with tooling.

@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Jul 31, 2016

Collaborator

Meh, whatever. I think ASCII quotes look super ugly but seems like nobody cares about this so I'm fine doing what most people do. :-)

namely when screenreaders vocalize the HTML character code as literal text instead of an ignored quote

Weird, I didn't known that. Do you mean that every single serious magazine on the web has this problem? I've never seen ASCII quotes on any serious website with text except tech docs but maybe I'm wrong.

Collaborator

gaearon commented Jul 31, 2016

Meh, whatever. I think ASCII quotes look super ugly but seems like nobody cares about this so I'm fine doing what most people do. :-)

namely when screenreaders vocalize the HTML character code as literal text instead of an ignored quote

Weird, I didn't known that. Do you mean that every single serious magazine on the web has this problem? I've never seen ASCII quotes on any serious website with text except tech docs but maybe I'm wrong.

@timdorr

This comment has been minimized.

Show comment
Hide comment
@timdorr

timdorr Jul 31, 2016

Member

Weird, I didn't known that. Do you mean that every single serious magazine on the web has this problem? I've never seen ASCII quotes on any serious website with text except tech docs but maybe I'm wrong.

It's more of an issue when the tooling gets in the way and converts a quote symbol to an HTML entity or a mangled UTF-8 entity ("don芒鈧劉t").

Member

timdorr commented Jul 31, 2016

Weird, I didn't known that. Do you mean that every single serious magazine on the web has this problem? I've never seen ASCII quotes on any serious website with text except tech docs but maybe I'm wrong.

It's more of an issue when the tooling gets in the way and converts a quote symbol to an HTML entity or a mangled UTF-8 entity ("don芒鈧劉t").

@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Jul 31, 2016

Collaborator

Do we have tooling doing that?

Collaborator

gaearon commented Jul 31, 2016

Do we have tooling doing that?

@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Jul 31, 2016

Collaborator

To be honest, I'm happy to stop caring about this, it's been an uphill battle for as long as I can remember. So I'm ok with this PR.

Collaborator

gaearon commented Jul 31, 2016

To be honest, I'm happy to stop caring about this, it's been an uphill battle for as long as I can remember. So I'm ok with this PR.

@markerikson

This comment has been minimized.

Show comment
Hide comment
@markerikson

markerikson Jul 31, 2016

Contributor

Heh. That makes my job a bit easier, but I can understand the desire to make things like kinda nice. Thanks, Dan :) And sorry, Dan :(

Contributor

markerikson commented Jul 31, 2016

Heh. That makes my job a bit easier, but I can understand the desire to make things like kinda nice. Thanks, Dan :) And sorry, Dan :(

@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Aug 1, 2016

Collaborator

OK let's do it. 馃槃

Collaborator

gaearon commented Aug 1, 2016

OK let's do it. 馃槃

@timdorr timdorr merged commit d18a977 into master Aug 1, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@timdorr timdorr deleted the ascii-quotes branch Aug 1, 2016

seantcoyote added a commit to seantcoyote/redux that referenced this pull request Jan 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment