New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redux-mock-store libdef for todos-flow #2430

Merged
merged 6 commits into from Jun 1, 2017

Conversation

2 participants
@lifeiscontent
Contributor

lifeiscontent commented May 29, 2017

Just updating a libdef to keep todos-flow at 100%

@timdorr

This comment has been minimized.

Show comment
Hide comment
@timdorr

timdorr May 29, 2017

Member

Hmm, this is going to get annoying. Are we sure we can't just dynamically pull the typedefs at build/test time?

Member

timdorr commented May 29, 2017

Hmm, this is going to get annoying. Are we sure we can't just dynamically pull the typedefs at build/test time?

@lifeiscontent

This comment has been minimized.

Show comment
Hide comment
@lifeiscontent

lifeiscontent May 30, 2017

Contributor

@timdorr should I just add a post install script for the package.json?

Contributor

lifeiscontent commented May 30, 2017

@timdorr should I just add a post install script for the package.json?

@timdorr

This comment has been minimized.

Show comment
Hide comment
@timdorr

timdorr May 30, 2017

Member

Yeah, that's probably going to be best. Manually maintaining these files is going to create a lot of noise in the commits over time.

Member

timdorr commented May 30, 2017

Yeah, that's probably going to be best. Manually maintaining these files is going to create a lot of noise in the commits over time.

@lifeiscontent

This comment has been minimized.

Show comment
Hide comment
@lifeiscontent

lifeiscontent Jun 1, 2017

Contributor

@timdorr all updated 👍

Contributor

lifeiscontent commented Jun 1, 2017

@timdorr all updated 👍

@timdorr

This comment has been minimized.

Show comment
Hide comment
@timdorr

timdorr Jun 1, 2017

Member

Awesome! Thanks!

Member

timdorr commented Jun 1, 2017

Awesome! Thanks!

@timdorr timdorr merged commit bf3a557 into reduxjs:master Jun 1, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

deminoth added a commit to deminoth/redux that referenced this pull request Jun 17, 2017

Merge branch 'upstream'
* upstream: (27 commits)
  3.7.0
  Removing the browser field for now
  Upgrade all example deps, including the universal example to Webpack 2
  Upgrade some other deps
  Upgrades and remove check-es3-syntax since Rollup breaks it always
  Fix a typo in the Immutable.js docs (reduxjs#2453)
  Fix redux-mock-store libdef for todos-flow (reduxjs#2430)
  give redux-subscriber some attention in StoreSetup.md (reduxjs#2433)
  syncing docs with recent PR (2431) (reduxjs#2432)
  'todo' const removal from reducers/todos.js (reduxjs#2431)
  Fix link to ImmutableData article
  Update redux.js (reduxjs#2428)
  Add 100% test coverage for todos-flow example (reduxjs#2413)
  Fix eslint warnings, update react-scripts (reduxjs#2420)
  chore(packages): Update npm packages in CRA examples (reduxjs#2419)
  Fixed a typo (reduxjs#2417)
  change var to const (reduxjs#2414)
  Prettier to recipes folder (reduxjs#2390)
  Prettier to api folder (reduxjs#2392)
  Prettier to advanced folder (reduxjs#2388)
  ...

seantcoyote added a commit to seantcoyote/redux that referenced this pull request Jan 14, 2018

Fix redux-mock-store libdef for todos-flow (reduxjs#2430)
* Update package.json
Update package.json for todos-flow

* Update libdefs for todos-flow

* Add jest to package.json to use libdef

* Add flow-typed directory to .eslintignore to stop eslint errors on examples

* Run flow-typed install on postinstall in todos-flow example

* Add eslint-disable-line to href
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment