Set cwd to project's base path when running yarn rw upgrade - #2081
Merged
Merged
Conversation
Member
|
Nice, thank you so much for this, and congrats on your first contribution to RedwoodJS! |
peterp
approved these changes
Mar 24, 2021
peterp
changed the title
cwd to project's base path when running yarn rw upgrade
Contributor
Author
|
Thanks! |
Contributor
Author
|
fyi i accidentally committed to this branch, then reverted. hope that doesn't mess anything up |
Contributor
|
Oh, nice! I'm attempting to get this into current release — retriggering Cypress now. (55min?? What in the world is wrong with our CI... 🤔 ) |
thedavidprice
approved these changes
Mar 24, 2021
Contributor
Author
|
Nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1659
used getPaths to get the base path, then added it to each execa with the cwd option
did some extremely rudimentary manual testing, so could definitely use some help on that front