From 0e13001e77b42f7dbc030dd8c03fe713de8847f7 Mon Sep 17 00:00:00 2001 From: Dominic Saadi Date: Fri, 1 Dec 2023 15:04:44 -0800 Subject: [PATCH] fix(crwa): pin Node.js version in `.nvmrc` (#9614) @Tobbe and I reproduced Netlify deploys failing on Node.js with the following Prisma error (only during run, not build, curiously): ``` Prisma Client could not locate the Query Engine for runtime "rhel-openssl-3.0.x".This happened because Prisma Client was generated for "debian-openssl-1.1.x", but the actual deployment required "rhel-openssl-3.0.x" ``` Netlify was deploying with Node.js 20, even if we set the `NODE_VERSION` env var to `18` in Netlify's deploy settings. It seemed like the `.nvmrc` file (which specified any lts version: `lts/*`) was taking precedence over the NODE_VERSION env var. This PR pins the Node.js lts version to 18 in the .nvmrc. We're not sure if we even need to ship with this file but this seemed like the safer change for now. Update: @Tobbe and I tried removing the `.nvmrc` file in a test deploy. Netlify defaulted to Node.js 16 which also isn't what we want, so it should stay. --- __fixtures__/empty-project/.nvmrc | 2 +- __fixtures__/test-project/.nvmrc | 2 +- packages/create-redwood-app/templates/js/.nvmrc | 2 +- packages/create-redwood-app/templates/ts/.nvmrc | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/__fixtures__/empty-project/.nvmrc b/__fixtures__/empty-project/.nvmrc index b009dfb9d9f9..3f430af82b3d 100644 --- a/__fixtures__/empty-project/.nvmrc +++ b/__fixtures__/empty-project/.nvmrc @@ -1 +1 @@ -lts/* +v18 diff --git a/__fixtures__/test-project/.nvmrc b/__fixtures__/test-project/.nvmrc index b009dfb9d9f9..3f430af82b3d 100644 --- a/__fixtures__/test-project/.nvmrc +++ b/__fixtures__/test-project/.nvmrc @@ -1 +1 @@ -lts/* +v18 diff --git a/packages/create-redwood-app/templates/js/.nvmrc b/packages/create-redwood-app/templates/js/.nvmrc index b009dfb9d9f9..3f430af82b3d 100644 --- a/packages/create-redwood-app/templates/js/.nvmrc +++ b/packages/create-redwood-app/templates/js/.nvmrc @@ -1 +1 @@ -lts/* +v18 diff --git a/packages/create-redwood-app/templates/ts/.nvmrc b/packages/create-redwood-app/templates/ts/.nvmrc index b009dfb9d9f9..3f430af82b3d 100644 --- a/packages/create-redwood-app/templates/ts/.nvmrc +++ b/packages/create-redwood-app/templates/ts/.nvmrc @@ -1 +1 @@ -lts/* +v18