Bump CRWA Node.js Engine requirement from 12 to 14 (#1946)

* bump template node engine; update GH Actions * add .nvmrc to template
redwoodjs · Mar 9, 2021 · 5dbb9e0 · 5dbb9e0
1 parent 42ec5eb
commit 5dbb9e0
Show file tree

Hide file tree

Showing 7 changed files with 21 additions and 11 deletions.
diff --git a/.github/workflows/build-eslint-jest.yaml b/.github/workflows/build-eslint-jest.yaml
@@ -11,15 +11,15 @@ jobs:
     strategy:
       matrix:
         os: ['ubuntu-latest', 'windows-latest']
-        node-version: ['14', '12']
+        node-version: ['14']
       fail-fast: true
     runs-on: ${{ matrix.os }}
     name: ${{ matrix.os }} | Node ${{ matrix.node-version }} latest
     steps:
       - uses: actions/checkout@v2
 
       - name: Setup node
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v2
         with:
           node-version: ${{ matrix.node-version }}
 

diff --git a/.github/workflows/create_pr_artifact.yaml b/.github/workflows/create_pr_artifact.yaml
@@ -16,7 +16,7 @@ jobs:
         uses: actions/checkout@v2
 
       - name: Setup node
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v2
         with:
           node-version: 14
 

diff --git a/.github/workflows/e2e.yaml b/.github/workflows/e2e.yaml
@@ -9,11 +9,21 @@ on:
 jobs:
   cypress-run:
     if: github.repository == 'redwoodjs/redwood'
-    runs-on: ubuntu-16.04
-
+    strategy:
+      matrix:
+        os: ['ubuntu-latest']
+        node-version: ['14']
+      fail-fast: true
+    runs-on: ${{ matrix.os }}
+    name: ${{ matrix.os }} | Node ${{ matrix.node-version }} latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v1
+        uses: actions/checkout@v2
+
+      - name: Setup node
+        uses: actions/setup-node@v2
+        with:
+          node-version: ${{ matrix.node-version }}
 
       - name: Install framework modules
         run: yarn install --frozen-lockfile
@@ -46,4 +56,4 @@ jobs:
           env: true
           wait-on: 'http://localhost:8910'
           record: true
-          working-directory: ./tasks/e2e
+          working-directory: ./tasks/e2e
diff --git a/.github/workflows/publish-npm-canary.yaml b/.github/workflows/publish-npm-canary.yaml
@@ -15,9 +15,9 @@ jobs:
         with:
           fetch-depth: 0 # Required because lerna uses tags to determine the version.
       - name: Setup node
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v2
         with:
-          node-version: '12'
+          node-version: '14'
       - name: Print node and yarn versions
         run: |
           node --version

diff --git a/.gitignore b/.gitignore
@@ -1,6 +1,5 @@
 .idea
 .DS_Store
-.nvmrc
 node_modules
 dist
 lerna-debug.log

diff --git a/packages/create-redwood-app/template/.nvmrc b/packages/create-redwood-app/template/.nvmrc
@@ -0,0 +1 @@
+lts/*
diff --git a/packages/create-redwood-app/template/package.json b/packages/create-redwood-app/template/package.json
@@ -15,7 +15,7 @@
     "root": true
   },
   "engines": {
-    "node": ">=12",
+    "node": ">=14",
     "yarn": ">=1.15"
   },
   "resolutions": {