New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tailwindcss setup #1407
Fix tailwindcss setup #1407
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
@mohinderps Woah, this is a ton of work and the functionality is 💯 Thank you for taking the time to get this one right. It's so helpful. There's an incoming PR #1408 that will add an option to this command. The plan is to merge this first. However, I do want to loop in the author of #1408 to see what you've done and give any feedback before I merge (he's a great guy and has been helpful with Redwood since March). Once we have a coordinated plan, I'll merge. I expect this should be a quick turnaround. Just let me know if you have any questions. |
Looping in @olance who's working on extending the command with an option via #1408 I suggested a plan for us to discuss:
Open to more discussion as needed. And, most of all, thank you both! |
Thank you @thedavidprice for such kind words. You have been of great help to me. I just followed your directions. And also if everything looks fine to you, can you also add hacktoberfest-accepted label ? So that this is counted as my hacktoberfest contribution. |
re: |
Cool @thedavidprice ! |
👋 Thanks for the ping @thedavidprice :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 👍
Just added a suggestion on renaming tailwindImportsDoesExist
to tailwindImportsExist
, which does simplify the code a little bit as well as fixing a grammatical error ^^
Co-authored-by: Olivier Lance <olance@users.noreply.github.com>
Co-authored-by: Olivier Lance <olance@users.noreply.github.com>
Merging this now. Thanks again @mohinderps 🚀 |
Closes #1301
This is draft PR, which fixed tailwindcss setup command. Feel free to review this and suggest the changes that need to done.