Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create @redwoodjs/forms #886

Merged
merged 6 commits into from Jul 26, 2020
Merged

Create @redwoodjs/forms #886

merged 6 commits into from Jul 26, 2020

Conversation

peterp
Copy link
Contributor

@peterp peterp commented Jul 23, 2020

Not everyone will be using Redwood's forms, so moving it to a separate package reduces @redwoodjs/web by: -9kb (lol)

Right now user's will still be able to use the imports from @redwoodjs/web, but it will display this deprecation notice:

Deprecation notice, forms have moved:
    'import { Form } from "@redwoodjs/web"' has moved.
    Please use:
    'import { Form } from "@redwoodjs/forms"' instead.

Even though the reduction isn't that great I still think it's a good idea to have it in a focused package.

@peterp peterp requested a review from cannikin July 23, 2020 20:50
packages/forms/tsconfig.json Outdated Show resolved Hide resolved
@peterp peterp marked this pull request as draft July 23, 2020 21:21
@peterp peterp force-pushed the pp-make-forms-own-package branch from d68c0c1 to b498ba9 Compare July 26, 2020 05:46
@peterp peterp marked this pull request as ready for review July 26, 2020 05:59
@peterp peterp merged commit d81c939 into main Jul 26, 2020
@thedavidprice thedavidprice deleted the pp-make-forms-own-package branch July 28, 2020 05:29
@thedavidprice
Copy link
Contributor

@peterp I believe this introduced a bug in main. I opened an issue here #901

@thedavidprice thedavidprice added this to the next release milestone Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants