This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
e85d9cf
to
5bca349
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #338 +/- ##
==========================================
+ Coverage 18.23% 18.38% +0.14%
==========================================
Files 512 514 +2
Lines 51248 51602 +354
Branches 639 640 +1
==========================================
+ Hits 9344 9485 +141
- Misses 41869 42082 +213
Partials 35 35
|
keiya01
commented
Oct 31, 2022
src/components/molecules/Visualizer/Engine/Cesium/Box/index.tsx
Outdated
Show resolved
Hide resolved
keiya01
commented
Oct 31, 2022
KaWaite
reviewed
Oct 31, 2022
KaWaite
reviewed
Oct 31, 2022
KaWaite
reviewed
Oct 31, 2022
KaWaite
reviewed
Oct 31, 2022
src/components/molecules/Visualizer/Engine/Cesium/Box/index.tsx
Outdated
Show resolved
Hide resolved
KaWaite
reviewed
Oct 31, 2022
src/components/molecules/Visualizer/Engine/Cesium/Box/index.tsx
Outdated
Show resolved
Hide resolved
KaWaite
reviewed
Oct 31, 2022
src/components/molecules/Visualizer/Engine/Cesium/Box/index.tsx
Outdated
Show resolved
Hide resolved
rot1024
suggested changes
Nov 2, 2022
src/components/molecules/Visualizer/Engine/Cesium/Box/index.tsx
Outdated
Show resolved
Hide resolved
src/components/molecules/Visualizer/Engine/Cesium/Tileset/index.tsx
Outdated
Show resolved
Hide resolved
KaWaite
approved these changes
Nov 7, 2022
rot1024
approved these changes
Nov 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I added clipping box feature.
This clip the 3dtileset inside the box.
Clipping box plugin is here.
What I've done
What I haven't done
How I tested
Screenshot
Screen.Recording.2022-10-28.at.23.05.40.mov
Which point I want you to review particularly
Memo