From 5e41ba70fbfcb02d04a4e4e213d4cc6a1cd7ad7c Mon Sep 17 00:00:00 2001 From: keiya sasaki Date: Mon, 11 Sep 2023 17:21:16 +0900 Subject: [PATCH] chore(web): fix HBAO error when Cesium is destroyed (#675) --- .../beta/lib/core/engines/Cesium/useOverrideGlobeShader.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/web/src/beta/lib/core/engines/Cesium/useOverrideGlobeShader.ts b/web/src/beta/lib/core/engines/Cesium/useOverrideGlobeShader.ts index 7ac6e80ae6..bb8c47f64f 100644 --- a/web/src/beta/lib/core/engines/Cesium/useOverrideGlobeShader.ts +++ b/web/src/beta/lib/core/engines/Cesium/useOverrideGlobeShader.ts @@ -127,8 +127,10 @@ export const useOverrideGlobeShader = ({ defines: baseFragmentShaderSource.defines, }); return () => { - // Reset customized shader to default - makeGlobeShadersDirty(globe); + if (!globe.isDestroyed()) { + // Reset customized shader to default + makeGlobeShadersDirty(globe); + } }; }, [ sphericalHarmonicCoefficientsRefFunc,