New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Radion override and better support for DCPump Custom mode #250

Merged
merged 2 commits into from Jan 19, 2019

Conversation

Projects
None yet
2 participants
@sbidny
Copy link

sbidny commented Jan 18, 2019

Fixes #210. Seems that the RadionWrite() needed to be calling GetChannel() instead of access the array directly, so it could pull in overridden channels.

Also added better support for DCPump Custom mode, which allows the user to set the Custom mode sync and anti-sync speeds via the SetMode() call. This will then utilize the feeding and water change speeds of the DCPump class. And it has the added benefit of playing nicer with the UApp, which didn't really like the Custom mode if you didn't call SetMode() with Custom.

sbidny added some commits Jan 17, 2019

Better support for DCPump Custom mode
Added some variable initialization as well.
Call GetChannel() for RF RadionWrite()
Instead of accessing array, call GetChannel() to allow for overrides.

@robertoimai robertoimai merged commit cc00674 into reefangel:dev Jan 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment