Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFix for Radion override and better support for DCPump Custom mode #250
Conversation
sbidny
added some commits
Jan 17, 2019
robertoimai
merged commit cc00674
into
reefangel:dev
Jan 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
sbidny commentedJan 18, 2019
Fixes #210. Seems that the RadionWrite() needed to be calling GetChannel() instead of access the array directly, so it could pull in overridden channels.
Also added better support for DCPump Custom mode, which allows the user to set the Custom mode sync and anti-sync speeds via the SetMode() call. This will then utilize the feeding and water change speeds of the DCPump class. And it has the added benefit of playing nicer with the UApp, which didn't really like the Custom mode if you didn't call SetMode() with Custom.