Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use serde derive instead? #70

Closed
tiby312 opened this issue Nov 12, 2020 · 1 comment
Closed

Use serde derive instead? #70

tiby312 opened this issue Nov 12, 2020 · 1 comment

Comments

@tiby312
Copy link

tiby312 commented Nov 12, 2020

If this is a good idea, I could do a pull request
https://serde.rs/no-std.html

@mbrubeck
Copy link
Collaborator

Hmm. This would simplify the code, but it would also increase the number of build-dependencies and the time required to compile them.

If I were writing this code from scratch, I would use typically use #[derive]. But since the manual impls are already written, and aren't much of a maintenance burden, I don't see much reason to switch to #[derive].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants