From 802f8e55f9df90fd7002a653200c961681c1f161 Mon Sep 17 00:00:00 2001 From: yakov116 <16872793+yakov116@users.noreply.github.com> Date: Thu, 7 Jul 2022 10:24:41 -0400 Subject: [PATCH 1/3] Add "Status: Closed as not planned" to `isClosedPR` --- index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.ts b/index.ts index 133a128e..a2ba048d 100644 --- a/index.ts +++ b/index.ts @@ -266,7 +266,7 @@ collect.set('isQuickPR', [ export const isDraftPR = (): boolean => exists('#partial-discussion-header [title="Status: Draft"]'); export const isOpenPR = (): boolean => exists('#partial-discussion-header [title="Status: Open"], #partial-discussion-header [title="Status: Draft"]'); export const isMergedPR = (): boolean => exists('#partial-discussion-header [title="Status: Merged"]'); -export const isClosedPR = (): boolean => exists('#partial-discussion-header [title="Status: Closed"], #partial-discussion-header [title="Status: Merged"]'); +export const isClosedPR = (): boolean => exists('#partial-discussion-header :is([title="Status: Closed"], [title="Status: Merged"], [title="Status: Closed as not planned]")'); export const isReleases = (url: URL | HTMLAnchorElement | Location = location): boolean => getRepo(url)?.path === 'releases'; collect.set('isReleases', [ From 1652853ac130dd51374227ffbf611e56e5717cb8 Mon Sep 17 00:00:00 2001 From: yakov116 <16872793+yakov116@users.noreply.github.com> Date: Thu, 7 Jul 2022 10:58:51 -0400 Subject: [PATCH 2/3] deprecate `isClosedPR` --- index.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/index.ts b/index.ts index a2ba048d..2409330f 100644 --- a/index.ts +++ b/index.ts @@ -266,7 +266,11 @@ collect.set('isQuickPR', [ export const isDraftPR = (): boolean => exists('#partial-discussion-header [title="Status: Draft"]'); export const isOpenPR = (): boolean => exists('#partial-discussion-header [title="Status: Open"], #partial-discussion-header [title="Status: Draft"]'); export const isMergedPR = (): boolean => exists('#partial-discussion-header [title="Status: Merged"]'); -export const isClosedPR = (): boolean => exists('#partial-discussion-header :is([title="Status: Closed"], [title="Status: Merged"], [title="Status: Closed as not planned]")'); +export const isClosedConversation = (): boolean => exists('#partial-discussion-header :is([title="Status: Closed"], [title="Status: Merged"], [title="Status: Closed as not planned]")'); +/** +@deprecated Use isClosedConversation +*/ +export const isClosedPR = isClosedConversation; export const isReleases = (url: URL | HTMLAnchorElement | Location = location): boolean => getRepo(url)?.path === 'releases'; collect.set('isReleases', [ From da62012d9d8ce6a03ad74cd7c249641c29c05a8a Mon Sep 17 00:00:00 2001 From: yakov116 <16872793+yakov116@users.noreply.github.com> Date: Thu, 7 Jul 2022 12:06:29 -0400 Subject: [PATCH 3/3] One line --- index.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/index.ts b/index.ts index 2409330f..0521c6bf 100644 --- a/index.ts +++ b/index.ts @@ -267,9 +267,7 @@ export const isDraftPR = (): boolean => exists('#partial-discussion-header [titl export const isOpenPR = (): boolean => exists('#partial-discussion-header [title="Status: Open"], #partial-discussion-header [title="Status: Draft"]'); export const isMergedPR = (): boolean => exists('#partial-discussion-header [title="Status: Merged"]'); export const isClosedConversation = (): boolean => exists('#partial-discussion-header :is([title="Status: Closed"], [title="Status: Merged"], [title="Status: Closed as not planned]")'); -/** -@deprecated Use isClosedConversation -*/ +/** @deprecated Use isClosedConversation */ export const isClosedPR = isClosedConversation; export const isReleases = (url: URL | HTMLAnchorElement | Location = location): boolean => getRepo(url)?.path === 'releases';