Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint #5830

Merged
merged 12 commits into from Jul 19, 2022
Merged

Lint #5830

merged 12 commits into from Jul 19, 2022

Conversation

fregante
Copy link
Member

@fregante fregante commented Jul 15, 2022

- combine position with getNewElement
- allow multiple attachments in a single call
@fregante fregante added the meta Related to Refined GitHub itself label Jul 15, 2022
readme.md Show resolved Hide resolved
@kidonng
Copy link
Member

kidonng commented Jul 16, 2022

I think we should mention Safari here?

- All the [latest DOM APIs](https://github.com/WebReflection/dom4#features) and JavaScript features are available because the extension only has to work in the latest Chrome and Firefox. 🎉

That said, I'm not sure about our stance on latest version of Safari. It is unique as it is
slow in feature support (until recently), a system component which is not something automatically updated in a few days (not sure) on macOS, and tied to system version on iOS (not something we particular care though).

I looked at past examples: :is() is added in Safari 14 (released on Sep 16, 2020) and used in RGH in #4041 (opened in Mar 1, 2021, ~5.5 months later). If we continue on this track, we can use Array#at() and :has() this September (coincidentally, this is also when Chrome 105 with :has() support will be released; not counting Firefox, that is).

@fregante
Copy link
Member Author

fregante commented Jul 17, 2022

:has() this September (coincidentally, this is also when Chrome 105 with :has() support will be released; not counting Firefox, that is).

10% of our users are on Firefox and I'm afraid we won't be able to use a native has for a loooong time. They mentioned they have to rewrite their invalidation logic for the selector to work, and they're not even sure it's worth the drawback. 😰

I'm not sure about our stance on latest version of Safari.

Almost the same as other browsers. We generally don't require the very last version, there's rarely a new feature that forces us to think about this.

@fregante fregante marked this pull request as ready for review July 19, 2022 17:25
@fregante fregante merged commit f2c0725 into main Jul 19, 2022
@fregante fregante deleted the lint-beans branch July 19, 2022 17:25
@kidonng
Copy link
Member

kidonng commented Jul 21, 2022

They mentioned they have to rewrite their invalidation logic for the selector to work, and they're not even sure it's worth the drawback. 😰

At least there's some work being done: https://bugzilla.mozilla.org/show_bug.cgi?id=1771896

Almost the same as other browsers. We generally don't require the very last version, there's rarely a new feature that forces us to think about this.

Basically I'm just saying Safari is not as "evergreen" as other browsers, in the way new versions are delivered. We have to draw the line somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Related to Refined GitHub itself
Development

Successfully merging this pull request may close these issues.

None yet

3 participants