fix bugs with globalize, published_before and clean code #276

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

keram commented Aug 29, 2012

little correction to this 50661cc
Post.tagged_with.. need to be called with "live"
Also fix method "next" which needs be called also with "live",
and then remove unecessary with_globalize because it is in "live" method yet.

Owner

ugisozols commented Aug 29, 2012

First of all this can't be merged automatically again - does your branch have all the commits from our master branch?

Second - it would be really nice to have specs so that we don't break this in the future.

Contributor

keram commented Aug 29, 2012

First of all this can't be merged automatically again - does your branch have all the commits from our master branch?

strange ;/ I miss update master for upstream, now I hope it can be merged properly...

Second - it would be really nice to have specs so that we don't break this in the future.

I agree! :) It would be very nice if somebody do that .)
I would appreciate also if my pull request are merged little faster https://github.com/refinery/refinerycms-blog/pulls :)
because I start forgetting where, when and what I fix before ;/.

Owner

parndt commented Aug 29, 2012

You don't want to write specs? :p

Contributor

keram commented Aug 30, 2012

I wish had the time and resources for that. ;/

@parndt parndt closed this in f6dbe31 Nov 22, 2012

Owner

parndt commented Nov 22, 2012

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment