Rails 4 support. #368

Merged
merged 8 commits into from Feb 3, 2014

Conversation

Projects
None yet
4 participants
Owner

ugisozols commented Jan 27, 2014

No description provided.

Contributor

jurriaan commented Jan 27, 2014

Awesome! 👍

Contributor

jurriaan commented Jan 27, 2014

There are a few deprecation warnings:

 The :distinct option for `Relation#count` is deprecated. 
 Calling #find(:all) is deprecated. 
 Relation#all is deprecated.
Owner

ugisozols commented Jan 27, 2014

Deprecations are from https://github.com/resolve/filters_spam but I have already fixed them there.

Contributor

jurriaan commented Jan 27, 2014

You’re right. I saw there were two other instances of Relation#all on your branch which aren’t triggered by the test:

https://github.com/refinery/refinerycms-blog/blob/rails4/app/controllers/refinery/blog/admin/posts_controller.rb#L93
https://github.com/refinery/refinerycms-blog/blob/rails4/db/seeds.rb#L1

Owner

ugisozols commented Jan 27, 2014

If you're referring to Relation#all is deprecated. then that's from .find(:all) which was used in filters_spam.

Plain .all is fine :)

Contributor

jurriaan commented Jan 27, 2014

I’m sorry. You’re totally right :) I’ve misinterpreted the error message and some posts on the internet.

Owner

parndt commented Jan 27, 2014

Feel free to pull request filters_spam ;)

Member

simi commented Jan 27, 2014

resolve/filters_spam@75cbd47

2014-01-27 Philip Arndt notifications@github.com

Feel free to pull request filters_spam ;)


Reply to this email directly or view it on GitHubhttps://github.com/refinery/refinerycms-blog/pull/368#issuecomment-33359175
.

Owner

parndt commented Jan 27, 2014

Haha awesome!!

parndt merged commit a6ec37c into master Feb 3, 2014

1 check passed

default The Travis CI build passed
Details

parndt deleted the rails4 branch Feb 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment