Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

From name should be more descriptive #82

Closed
parndt opened this Issue · 10 comments

3 participants

Philip Arndt Uģis Ozols Rob Yurkowski
Philip Arndt
Owner

Say my site_name is set to Philip Arndt
And my domain name is philiparndt.name
And the person contacting me is called Rob Yurkowski
Then I should see the from name in my email inbox as:

[Philip Arndt] Rob Yurkowski

Or

Rob Yurkowski [Philip Arndt]

Or

Rob Yurkowski [philiparndt.name]

Or

[philiparndt.name] Rob Yurkowski

Feedback please

Uģis Ozols
Owner

Uģis Ozols (ugisozols.lv)

Philip Arndt
Owner
parndt commented

@robyurkowski what do you think

Rob Yurkowski

I rather prefer [Philip Arndt] Rob Yurkowski, but I think we should probably do Rob Yurkowski [Philip Arndt] so that the most-significant information is closest to the left.

Philip Arndt
Owner
parndt commented

Okay thanks. I think having the URI not the name of the site is more descriptively obvious otherwise I'm just seeing two names

Uģis Ozols
Owner

So which one? I want to take this low hanging fruit :)

Philip Arndt
Owner
parndt commented
Uģis Ozols
Owner
config.from_name = "Foo"
"[#{Refinery::Core.site_name}] #{::I18n.t('from_name', :scope => 'refinery.inquiry.config', :default => config.from_name)}"

?

Philip Arndt
Owner
parndt commented

No the whole thing would have to be configurable so:

I18n.t('from_name', :scope => 'refinery.inquiry.config', :site_name => Refinery::Core.site_name, :name => @inquiry.name)

Or something

Uģis Ozols
Owner

What about <no-reply@#{request.domain}> part? Should we keep it?

Philip Arndt
Owner
parndt commented

I don't think that's related to this as it still has to come from the website

Philip Arndt parndt closed this in #111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.