Add option to always send notification #112

Merged
merged 1 commit into from Jun 27, 2013

Conversation

Projects
None yet
3 participants
Contributor

Tranquility commented Jun 25, 2013

I made the experience that the spam filter marks real messages as spam. Maybe that happens because it can not really handle german messages. I am not sure, but my simple solution for now is to send always a notification so the user can doublecheck the message.

Owner

ugisozols commented Jun 25, 2013

I like the feature but I'm not sold on config name... and I don't have anything to offer either :)

Contributor

Tranquility commented Jun 25, 2013

Yes, I realized that the name is bad after I opened the pull request and thought about creating a new one. But then I decided to wait for some feedback :)

It's really hard to think of a good name.

Some suggestions:

  • always_send_notification
  • send_notification_for_spam
Owner

ugisozols commented Jun 25, 2013

config.send_notifications_for_inquiries_marked_as_spam

It may seem verbose but it communicates its intent very clearly. WDYT?

Contributor

Tranquility commented Jun 25, 2013

Yeah, makes probably most sense to be that verbose. I will use that one.

Contributor

Tranquility commented Jun 27, 2013

@ugisozols is there anything else you would like to have improved? I would love to see that merged.

Owner

ugisozols commented Jun 27, 2013

Oh, didn't see you have updated this PR. Could you please squash commits? After that I'll merge right away.

Contributor

Tranquility commented Jun 27, 2013

Done... Thanks!

ugisozols added a commit that referenced this pull request Jun 27, 2013

Merge pull request #112 from Tranquility/master
Add option to always send notification

@ugisozols ugisozols merged commit 8e66c00 into refinery:master Jun 27, 2013

vijiram commented Sep 27, 2013

Mail is not sending in refinerycms inquiries.Is there any need to configure for sending mail?I updated in the who gets notified option.And also can i send to more than one mail id by using who gets notified options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment