Refactor #2 #141

Merged
merged 11 commits into from Jan 29, 2014

Projects

None yet

4 participants

@ugisozols
Member

This builds on top of #124.

@ugisozols
Member

@parndt ping ;)

@parndt parndt merged commit 7137a26 into master Jan 29, 2014

1 check passed

default The Travis CI build passed
Details
@parndt parndt deleted the refactor_2014 branch Jan 29, 2014
@gwagener gwagener commented on the diff Apr 30, 2014
refinerycms-inquiries.gemspec
@@ -14,7 +14,7 @@ Gem::Specification.new do |s|
s.files = `git ls-files`.split("\n")
s.test_files = `git ls-files -- spec/*`.split("\n")
- s.add_dependency 'refinerycms-core', '>= 2.1.0'
- s.add_dependency 'refinerycms-settings', '>= 2.1.0'
+ s.add_dependency 'refinerycms-core', '~> 3.0.0.dev'
+ s.add_dependency 'refinerycms-settings', '~> 3.0.0.dev'
@gwagener
gwagener Apr 30, 2014 Contributor

refinerycms-settings master branch is at version 2.1.0.dev so it fails to install the dependency. https://github.com/parndt/refinerycms-settings/blob/master/refinerycms-settings.gemspec#L6

@ugisozols
ugisozols Apr 30, 2014 Member

You're linking to @parndt's fork of refinerycms-settings. https://github.com/refinery/refinerycms-settings/blob/master/refinerycms-settings.gemspec has the correct version.

@gwagener
gwagener Apr 30, 2014 Contributor

Ah, yes. Sorry. Realised at the end of the day yesterday that my upstream remote for refinerycms-settings is woefully out of date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment