Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

update to 2.1.0 #40

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

Matho commented Aug 31, 2013

Hi. Seems it works with 2.1 without problems.

Martin

Owner

ugisozols commented Sep 2, 2013

This can't be merged in automatically. @Matho could you rebase this? Thanks!

I'm happy to help out here. Should the master branch should be used as a basis for a pull request?

@ugisozols how are new stable branches usually created? I can't see how a normal pull request can help here.

Also, I am wondering how developers would normally test refinerycms-search. When I tried running the specs, it tried to load a non-existent file: https://github.com/refinery/refinerycms-search/blob/master/spec/spec_helper.rb#L10

I'd love to help but need some guidance.

@keithpitty keithpitty referenced this pull request in refinery/refinerycms-blog Oct 22, 2013

Closed

No version compatible with refinerycms 2.1.0 #353

@ugisozols ugisozols closed this Oct 22, 2013

Owner

ugisozols commented Oct 22, 2013

@ugisozols how are new stable branches usually created? I can't see how a normal pull request can help here.

You can't create new branch with a PR. You need write access for this repo to create one but fear not - I've already created 2-1-stable.

Owner

ugisozols commented Oct 22, 2013

Also, I am wondering how developers would normally test refinerycms-search. When I tried running the specs, it tried to load a non-existent file: https://github.com/refinery/refinerycms-search/blob/master/spec/spec_helper.rb#L10

Did you generate dummy application before running specs? rake refinery:testing:dummy_app - after this you should be able to run rspec spec/.

Ah, thanks. I missed that step.

@parndt parndt added a commit that referenced this pull request Oct 22, 2013

@parndt parndt Add proper dependency to refinerycms-core 2.1.0 and refinerycms-acts-…
…as-indexed 1.0.0

Per #40
e027bbc
Owner

parndt commented Oct 22, 2013

@keithpitty @ugisozols are you happy with the current version that master is? Shall it be released?

@parndt sounds like a plan to me.

Owner

ugisozols commented Oct 22, 2013

As there are no open issues I would say push 2.1.0 to rubygems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment