Skip to content


Subversion checkout URL

You can clone with
Download ZIP

Comparing changes

Choose two branches to see what's changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
base fork: refinery/refinerycms
head fork: refinery/refinerycms
Checking mergeability… Don't worry, you can still create the pull request.
This comparison is big! We're only showing the most recent 250 commits
Commits on Jul 14, 2010
@parndt parndt This is the only way that this command will work in Ruby 1.9.2 - by e…
…ntering the directory using 'cd' instead of Dir.chdir

Also ensure that bundler is available before the command runs by telling the user to install it.
@parndt parndt We don't need to raise, we can just puts and exit. f02841b
Commits on Jul 15, 2010
@parndt parndt Tightened up security around inserting images and resources (you can …
…no longer upload an image or resource inside the dialogues if you can't access the plugin itself). Also allows users to insert an image or resource that was previously uploaded even if they can't access the rest of the plugin. Fixed pagination on resource dialogues. Closes GH-110
@parndt parndt Fixes typo introduced with last commit that set pages per dialog to 1…
… not 12.
@parndt parndt No longer allow users to run this task if their apps already contain …
…a Gemfile as the results could be explosive.
@parndt parndt Update changelog and gemspec. 5928049
@parndt parndt Don't run the refinerycms task for the user, make them run it. Copy .…
…gitignore in a rake refinery:update
@parndt parndt Wonder why that wasn't html.erb 1e254f2
@parndt parndt Add support for an extra per page setting for dialogs with sizing opt…
…ions like that used in the wymeditor.
@parndt parndt Bit easier to read, really. Dialog can be a bit smaller. 4315d12
@parndt parndt slight CSS redux a529b85
@parndt parndt Regenerated gemspec to encompass all the changes of late. 16d5b95
@parndt parndt document final change 4cafe27
@parndt parndt Link love d1b72bd
@magpieuk magpieuk Fix for Mysql Specific code 12db7ee
@parndt parndt Fixes singular_name into the interpreted version so that locales work…
… in generated plugins.
@parndt parndt Update changelog d7cc36c
Commits on Jul 16, 2010
@parndt parndt update changelog for Lee's change. 905c13a
Commits on Jul 17, 2010
@djones djones fix broken link a18b365
Commits on Jul 19, 2010
@parndt parndt Rework the way that dialogues work internally and hook into a dialogu…
…e on the greeting message.
@parndt parndt Report the correct task to run and add separate stylesheets for diffe…
…rent IE versions (sigh). Update version number for when we next release.
@parndt parndt Just tidier and easier to read. d1460a2
@parndt parndt Don't need the ternary, it'll return nil if the condition is false an…
@parndt parndt Remove sham begin without any rescue and redirect after setting every…
…thing else.
@parndt parndt was just too long. 32316b5
@parndt parndt whoops. c04c2da
@parndt parndt readability. 2630d75
Steven Heidel Refactored Version slightly to allow for specific parts of the versio…
…n (major, minor, tiny, or build) to be accessed.

This could be useful for plugin authors to ensure that their plugins are backwards compatible.
@parndt parndt Support redirecting back to the session[:return_to] when we save a se…
…tting from the dialogue.
@djones djones fix syntax error in existing resource dialog b225f68
@djones djones fix resource picker that just disappears on load. Now it won't do that d1f6f83
Steven Heidel Refactored .gitignore file so that it is easier to read.
Also added ignores for Redcar.
Steven Heidel Merge branch 'master' of git:// c995d3d
Steven Heidel Moved translation tasks to lib/tasks in order to fix deprecation warn…
Steven Heidel Added task refinery:test_all to run test_unit, rspec, and cucumber. T…
…ests remain buggy however.
@parndt parndt Thanks, Steven. 7244e85
@parndt parndt IE... b31627f
@parndt parndt Use latest placeholder shim from… e5d75f1
@parndt parndt Merge remote branch 'stevenheidel/master' dd4f12b
Commits on Jul 20, 2010
@parndt parndt Refresh gemspec, fix whitespace and translate the user mailer properl…
…y as I18n.translate('.link_to_reset_your_password') doesn't seem to work the same as t('.link_to_reset_your_password')
@joemsak joemsak Positioning bug in dialog boxes 6732842
@parndt parndt Additional to Joe's last commit, it is important that form-actions in…
…side iframes have position: fixed so that scrolling works with the effect of the form-actions still sitting at the bottom of the dialogue window.
@parndt parndt Come on, IE. Just because there's something on the page with this dom…
… ID doesn't mean I wanted it unless I document.getElementById() or it.

When selecting something, it helps IE if you don't call your variable the same thing as an existing DOM ID on the page.
@djones djones don't load rake tasks in twice that already belong to this application. c70b15b
@parndt parndt OK, so more stuff happened. Oh and we released a new version. 3c90fd5
@parndt parndt Last minute fix added. 18d1a9a
@djones djones new google group url 0f76986
@djones djones update dashboard feature 459044b
@djones djones the binary is called refinerycms now not refinery a74168f
Steven Heidel Added cucumber and gherkin to the Gemfile. This will ensure that (in …
…/home/steven/refinerycms/master) works correctly.

If you are still having problems then uninstall all other versions of cucumber and gherkin than those specified in the Gemfile.
@parndt parndt Use a version of cucumber that supports spork and use spork as the de…
…fault on OS that isn't Windows. Remove hardcoded config.gem specified by cucumber as we use Bundler and don't need them.
@parndt parndt put rspec back. a0c08a3
@parndt parndt We need spork to be filtered by OS, not launchy. 94277cf
@parndt parndt relock. ebdba74
@awagener awagener Merge branch 'master' of 74d150c
@awagener awagener Readded quotes accidentally removed in commit df64890, causes resourc…
…e picker to throw undefined method 'titleize' NoMethodError
@parndt parndt You know, we seem to be working just fine without locking you to gher…
…kin 2.0.2 since we removed config.gem from cucumber.rb environment file.
@awagener awagener Add db/seeds directory if it doesn't exist when generating a new plugin 50e554f
@parndt parndt Merge remote branch 'awagener/master' 7239c47
@parndt parndt Merge branch 'cucumber-testing' c1965ea
@jamesfid jamesfid Fixed mswin inclusion/exclusion criteria. 8329ca1
Commits on Jul 21, 2010
@jamesfid jamesfid Fixed inclusion/exclusion for win32 system requirements in Cucumber. 7844f9a
@parndt parndt whitespace b6848ec
Steven Heidel Updated installation steps for Heroku deployment. 7453c36
@parndt parndt Seems I have a new spec_helper.rb modification 3cbe582
@parndt parndt Merge remote branch 'stevenheidel/master' a4a2cec
@joemsak joemsak The stupid password fields keep auto filling in supported browsers...…
… eff that
Steven Heidel Remove config/stuff.yml from the .gitignore file on a gem install so …
…that it is easier to deploy.
@parndt parndt Merge remote branch 'stevenheidel/master' 3ce4e49
Steven Heidel That deserves a mention in the changelog. 749b705
@parndt parndt OK, we can use rmagick 2.12.0 - might help out Windows users. 8547e21
@parndt parndt Seems this is required for rake refinery:test_all edcde0b
@parndt parndt DRY up the readme given community resources now available thanks to s…
@parndt parndt Merge remote branch 'stevenheidel/master' 67c527f
@parndt parndt better test command.. cf7e03a
@djones djones rearranged the readme a little. Will shift the S3 instructions and ho…
…w to update refinery to a tutorial soon so we don't have to put that in our readme file
Commits on Jul 22, 2010
@parndt parndt Renamed rake refinery:test_all to rake test:refinery which was an exi…
…sting task but now runs spec and cucumber and benchmark too.
@parndt parndt Make sure that the version is incremented, remove empty rake file and…
… reject more things in the gemspec like log files.
@parndt parndt Encourage testing. 3f953d8
@parndt parndt Only use a fallback when one is specified. 3dd1f7d
@ken-guru ken-guru translated all english text sections to Norsk Bokmål. 0520653
@ken-guru ken-guru fixed one syntax error and one indentation error 36514d0
@ken-guru ken-guru changed wording on Dashboard list e5e011e
@joemsak joemsak When unchecked, settings restrictions save as nil, which still restri…
…cts them from regular users. A before_save callback sets it to false if it is submitted as nil
@parndt parndt Merge remote branch 'ken-guru/master' 834762d
Steven Heidel ToDo's tend to look better when there is less on them.
It looks like mostly everything is covered here, anything more long term can go on the 'suggestions' wiki page.
Steven Heidel Updated the readme, mainly just making links more current. 0dca73c
Commits on Jul 23, 2010
@parndt parndt Settings weren't re-caching when using RefinerySetting[]= 5d2f6df
@parndt parndt Allow delete confirmation prompt to be overriden (and thus localised)…
…, DRYed up the images locales, ensure that delete buttons have titles and fixed issue where the delete button wasn't working in some cases on forms' form_actions. Closes GH-112
@parndt parndt Fix condition where image thumbnail was nil. 8ac2d4b
@parndt parndt Merging Amanda's changes to placeholder shim. bb209ee
@parndt parndt prepare for release today. 13a7a18
@djones djones updated readme to be shorter, moved a few how tos into tutorials on t…
…he tutorial site
stevenheidel Corrected test rake task. 99ef97d
@parndt parndt How to... c8b4b05
@parndt parndt Merge remote branch 'stevenheidel/master' 65c23a6
@djones djones move testing instructions into a tutorial df824ca
@parndt parndt RSpec now only runs once when you run it. Refactored where the extra …
…load logic went to get it into vendor.
@parndt parndt Remove lib/refinery from client apps on update. 6653d05
@parndt parndt replace copy logic with rm logic. f942e96
@parndt parndt Dialog was incorrectly sized and closed even on an error on save click. 8daf954
Commits on Jul 24, 2010
Steven Heidel Don't record analytics when a user is logged in and admiring their site. 211f50f
@parndt parndt Disrobe, looks better without it.. 52c0a50
@parndt parndt This more accurately generates what we want to say. fa6f697
Steven Heidel Started to add an .rss feed to the dashboard.
However, recent_activity is very confusing and will probably need to be refactored.
Commits on Jul 25, 2010
@parndt parndt The home_page? of any given application is actually when it matches t…
…he root_url against the current request.path so that's what I've changed this to..
@parndt parndt readability win. 1eda791
Steven Heidel Merge branch 'master' of git:// 504e6ef
Steven Heidel Quote: 'The API needs to happen.' d08c8ae
@djones djones updated the todo list to reflect the 1.0 release requirements a321e5e
@parndt parndt Merge remote branch stevenheidel/master and solve conflict(s). 79f3c12
Commits on Jul 26, 2010
@parndt parndt I totally cuked on the plane today. 81a47d9
@andrewhavens andrewhavens Now hiding Eclipse .project files 365e4cf
@parndt parndt Add another feature - creating an invalid inquiry and add more steps …
…to the valid inquiry and its support files.
@parndt parndt Moved inquiries feature to create_inquiries and create a new manage i…
…nquiries feature for the backend.
@parndt parndt Add feature for seeing the list of inquiries when one exists. 065ca77
@parndt parndt Clean whitespace, terminate double quotes inside cucumber paths and w…
…rote a test for inquiries show feature.
@parndt parndt Wrote destroy test for inquiries. This has revealed that the flash no…
…tices for destroys aren't showing up. Todo: fix.
@jamesfid jamesfid Initial cucumber run commit. fd51e14
@jamesfid jamesfid Here are the step files/uploads dir 456bd25
@jamesfid jamesfid Revert "Initial cucumber run commit."
This reverts commit fd51e14.
@jamesfid jamesfid We need more Cucumbers. 4a7140f
@jamesfid jamesfid Revert "We need more Cucumbers."
This reverts commit 4a7140f.
@jamesfid jamesfid The more cucumbers, the better. d989d7e
@jamesfid jamesfid The more cucumbers, the better. 83cfa51
@parndt parndt document why test fails. 84a55cc
@parndt parndt was inhibiting destroy flashes as revealed in cucumber feat…
@parndt parndt Merge remote branch 'jamesfid/master' fd2d6a6
@parndt parndt relock 0d104b2
Steven Heidel Tag all the cucumber features. 1f28f4f
Commits on Jul 27, 2010
@parndt parndt press not click 203c473
@parndt parndt There may be a log out button 05389cf
@parndt parndt Document language option on dashboard through cucumber a6bdbc0
@parndt parndt Fix some features, still a couple broken because of confirmation dial…
…ogues etc.
@parndt parndt Make this feature do what it is supposed to which fails. ea1e1aa
@parndt parndt logged in user was too ambiguous. 5fc0f7e
@parndt parndt When we change the language to something other than English we have t…
…o change it back or the site remains in say, Slovenian, and throws out all the other features.
@parndt parndt Add scenario for adding a new page from the Dashboard which should re…
…turn to the Dashboard etc.
@jamesfid jamesfid Added image steps/features. a7cc0c1
@jamesfid jamesfid Cleaned up files/images features. Commented out failing delete scenar…
…ios in each.
@jamesfid jamesfid Minor tweaks to images feature. 57085c8
@parndt parndt No wonder cucumber couldn't find the Message label, they were just bo…
…lded text.
@parndt parndt Should always use path not url 63c0f50
@parndt parndt Whitespace and readability. 5d08362
@parndt parndt Sometimes you end up with 'nothing' commits. de4fc09
Commits on Jul 28, 2010
@parndt parndt Plugin's name is now refinery_pages 0916e9b
@parndt parndt Default url prefix to edit 8532416
@levicole levicole generate basic skeleton of a theme 34efb56
@djones djones fix left over merge tag 74299e3
@djones djones default the acitivity reporting api to use 'title' as the title attri…
…bute. This syncs it up with the same title default used in crud.rb too. Also keep the use of double quotes consistent
@djones djones halfway through renaming the refinery generator to the refinery_plugi…
…n generator and adding in the new refinery_theme generator
@djones djones improving the instructions 65f5c2d
@djones djones Improve the docs a little. lock using latest bundler. 01d8faf
@djones djones moving stuff around to make it work. At this point both generators do…
… work. Just need to tidy up and test
@djones djones use examples that work on Windows too 98efc9f
@djones djones ensure a theme name is supplied before creating a theme 14d8cf0
@djones djones taking out the sexy. Adding better and more accurate coverage of files fe2564a
@djones djones adding in tests. not done yet but basic structure there 1ca2d26
@djones djones fix typo 52deb9c
@djones djones cucumber tests now pass for both generating new themes and plugins bb00224
@djones djones oops this file required for passing tests 3390f33
@djones djones fix missing locale when generating a plugin 18dc810
@djones djones add deprecation instructions to the existing refinery generator bcf4337
@djones djones update documentation about themes to include the new generator b392d35
@djones djones Merge remote branch 'djones/master' 1c3dd06
@djones djones updated changelog to reflect changes made to the generators 635875a
@djones djones Fix typo in changelog 5bf0185
Commits on Jul 29, 2010
@parndt parndt Fix quirks in older versions of Refinery upgrading to this one. a0be695
@parndt parndt tidy up, prepare for new version next time it's due. 2a62284
@parndt parndt new lock bbe32aa
@parndt parndt Refactor to use pathname in far more places, cleaned up code. Closes G… f28b876
@parndt parndt Eradicate page_translations -- where did this come from? We don't use…
… it, no model for it.. gone
@parndt parndt ensure the next version contains the correct gem version 5fd8b79
@parndt parndt Updated the dreaded changelog. 7fd5704
@parndt parndt tick tick, tick tick 8dae18a
Commits on Jul 30, 2010
@parndt parndt Support email addresses in the username field using slugs. However, t…
…his doesn't change the fact that you can use either field to login. Relates to and closes GH-101
Steven Heidel Locking the bundle. 09833a8
@parndt parndt Still can't have passing tests, it seems. 26a209f
@parndt parndt This seems like a bad idea. ec20f81
@parndt parndt Appears to fix failing inquiries delete test by using envjs ac4eec0
Steven Heidel Fix merge conflict. 1384a0a
@parndt parndt not worth it just to test delete. cb65ee5
@ugisozols ugisozols workaround in cucumber inquiries feature for iframes. 05b047d
@parndt parndt 32 scenarios (32 passed) 258 steps (258 passed) 58d23d9
@parndt parndt All forms should be able to know whether they are modal or dialog or …
…not just by including the form actions partial.
@parndt parndt Time for a new version, document recent changes. 5c2a99c
@ugisozols ugisozols removed duplicate error message in file validation 1fc4643
@ugisozols ugisozols added missing confirmation message when deleting resource (previously…
… was using wrong translation entry)
@ugisozols ugisozols multiply MAX_SIZE_IN_MB constant in resource validation error message…
… so it returns correct value for kb/mb etc.
@parndt parndt after many frustrating debugging efforts when the simple problem was …
…being logged in, we are now able to disable individual CSS/JS included by the site bar. Example provided in demolicious theme layout (everything not excluded by default, which is to say the status quo is maintained by default).
@parndt parndt Reverts a couple of assumptions made in Ruby code and move them to co…
…nditional Javascript code instead.
Steven Heidel Fix another merge conflict with Gemfile.lock e2ec8f7
@ugisozols ugisozols leave commas in translation files as not every language require them …
…in the same place
Steven Heidel Fixed a bug with adding new resources. dcf016f
Steven Heidel Updated schema.rb b4b3a62
@djones djones fix typo in theme documentation 9db0b1c
Commits on Jul 31, 2010
@ugisozols ugisozols Merge remote branch 'resolve/master' 4c6efc5
@ugisozols ugisozols in image and resource model added .megabytes method call on MAX_SIZE_…
…IN_MB in file size validation error message
@parndt parndt Merge remote branch 'stevenheidel/master' f27041f
@parndt parndt Merge remote branch 'ugisozols/master' 856f460
@ugisozols ugisozols added missing confirmation message when deleting inquery (previously …
…was using wrong translatn entry)
@ugisozols ugisozols moved 'Inbox' and 'Spam' words to locale files and using their transl…
…ation in inqueries submenu rather than hardcoding them in view
@ugisozols ugisozols fix 'Upload a file' link not showing in dashboard quick tasks 187e559
Commits on Aug 01, 2010
@parndt parndt Merge remote branch 'ugisozols/master' dba285a
@ugisozols ugisozols removed 'Inbox' and 'Spam' translation entries from all language loca…
…le files (except English locale) as they were in English and in production if translation is missing it falls back to English
@ugisozols ugisozols fixed search so it actually searches trough inquiries (ham & spam sep…
…erated). Now escaping all search queries when they are shown back to user. Made 'Pages' search messages just like on other pages
@parndt parndt Merge remote branch 'ugisozols/master' 96b3b37
@parndt parndt prepare for a future release. d8ad843
@parndt parndt cleanup 74a9fd1
@parndt parndt show how to check e7f6f56
@parndt parndt try nesting lists. 7b6272e
@parndt parndt hyphens hold the answer. 104af95
@parndt parndt Fix confirmation issue on new records. 7948948
@parndt parndt Ok, new version. d311e04
Commits on Aug 02, 2010
@ugisozols ugisozols added passing cucumber tests for search (available in 'Images', 'File…
…s', 'Inquiries' and 'Pages')
@parndt parndt Fixed deprecations in search with how we used acts_as_indexed - updat…
…ed to with_query from find_with_index.
@parndt parndt It's been long enough, goodbye application.rb
This was to make Refinery work under older versions of Phusion Passenger and should no longer be required.
Put it back manually if your project requires it.
Commits on Aug 03, 2010
@parndt parndt Fixes superfluous bracket causing error. ca12470
@parndt parndt better note down what happened. 5872039
@parndt parndt We need uploads also. 23caf8a
@parndt parndt Be more specific so we don't get things like "\"/contact\"" as a link…
@parndt parndt We can't reasonably expect to see this content on the page given that…
… we create the pages with no content.
@parndt parndt Fixes for Tooltips:
Tooltips were not showing in dialogues, they now are.
Tooltips would not position properly above links, they now do.
The Tooltips' nibs (the arrow) would not sit properly centered above the element if the tooltip had to move for the browser window size, they now do.

Also fixed so that cancel buttons' titles could be completely disabled, before it was buggy.
@bofrede bofrede Made file executable. ac9e830
@bofrede bofrede Make sure the required alt attribute is created. b41d4c6
@bofrede bofrede Fixed invalid HTML in the backend pages listing. d159bd0
Commits on Aug 04, 2010
@parndt parndt Add support for list that passes back full <ul> tags around them. afc9b0e
@parndt parndt Switch HTML5 enabling script to a partial so that it's run by the pag…
…e ASAP otherwise IE *sometimes* doesn't run it.
@parndt parndt update changelog while trying something new. ed18daa
@parndt parndt bit of formatting c869d3d
@parndt parndt update gemspec and version number [still unreleased] e9e2bfe
@parndt parndt Very important to change the version here, too. 5c53b4c
@djones djones fix XSS vulnerability on page meta information by escaping the releva…
…nt fields properly
@ugisozols ugisozols added some cucumber tests. Tried to reduce noise in tests. Introduced…
… :'data-method' => 'delte' to pass 'Delete' tests.
@ugisozols ugisozols changed wording in cucumber tests cda8e1f
@parndt parndt requires relock? 1ecee35
@parndt parndt Merge remote branch 'ugisozols/master' d68cbb9
@ugisozols ugisozols changed title input field size (when adding new page part) so it woul…
…d fit window
@ugisozols ugisozols used translations from locale files and added new rather than hardcod…
…ing titles in views
@bofrede bofrede Danish translation started. 1caa39c
@bofrede bofrede Danish translation for WYMeditor. 1eb8b4b
@parndt parndt Merge remote branch 'ugisozols/master' 42a80fb
@parndt parndt use CSS class for widest rather than guessing the size 29a4fd3
@parndt parndt Just use the right one instead. Thanks Joe! 3ddbeba
Commits on Aug 05, 2010
@joemsak joemsak Grab the first attribute that is a string, not just the first attribu…
…te, as the dashboard activity reporter
Commits on Aug 06, 2010
@parndt parndt Added carousel to admin menu to prevent tab overload. 9696322
@kivanio kivanio added missing translations for pt-BR b11310e
Commits on Aug 07, 2010
@parndt parndt flori has released a new json version (hooray!!) so now we can use th…
…at instead. Closes GH-116
@parndt parndt Update changelog and version release date. 696ed19
@parndt parndt Update neglected, forgotten about link. 4ba7138