Skip to content
This repository
  • 827 commits
  • 423 files changed
  • 13 contributors
This comparison is big! We're only showing the most recent 250 commits
Feb 12, 2010
Philip Arndt use controller_name instead e748ca2
David Jones added unit tests to resources and refacted some image settings to be …
…a constant
David Jones Merge branch 'master' of c6b8e69
David Jones test type of content on resources 3600ef7
David Jones added unit tests to themes fc138fd
David Jones added known todos for tests ed3a982
David Jones format with markdown b0fdfb9
David Jones format with markdown f965879
Philip Arndt some preparation for Rails 3 06704f1
Philip Arndt Merge branch 'master' of 786e726
Philip Arndt tests don't pass without these apparently ccffcb6
Philip Arndt Prepare for Rails 3 some more. Things are all conditional and still w…
…ork in Rails 2.3.5
Feb 13, 2010
BUGFIX: attachment_fu should now work correctly on windows 2b74cfb
Feb 15, 2010
Philip Arndt Added ETag caching to the Rack ThemeServer and refactored code to mak…
…e it easier to understand. Allowed controllers to be used inside theme directories as themes may need to change what happens in a particular controller e.g. PagesController. Added new :head_libraries for use with content_for :head_libraries which appears always before content_for :head - this change was important because if you were using content_for :head inside a layout file and then inside a template file, the template file would win and render first which may ruin your javascript/css dependencies. Version
Philip Arndt Merge branch 'master' of 96499dc
Ensuring that page urls don't point to the admin namespace 0898d63
Feb 16, 2010
Philip Arndt Fix logic errors on content_page template and fix the refinery and re…
…finery-update-core commands to more correctly use config/environment.rb and config/application.rb
Philip Arndt copy in the new environment file if there's an application file which…
… will hold all of the important settings from now on
Philip Arndt fix updating the core and put the attachment fu patch in a more logic…
…al place and include it from the initializer not environment.rb
Philip Arndt you must enable etags to use them as they're causing bugs for some 8d78b38
David Jones use markdown format 803cd59
Philip Arndt By default we want to show logs 61de701
David Jones add more todos 36bb58a
Philip Arndt This little change reduces the number of database queries quite drama…
Philip Arndt Merge branch 'master' of 5d63b4f
Philip Arndt This logic wins fe9a6da
Philip Arndt update test to reflect new code 3707c15
Philip Arndt Use Pathname for Refinery.root (was REFINERY_ROOT) wherever possible.…
… Some occurances still remain where 'refinery' doesn't exist e.g. in the bin tasks. Specified the load order of plugins so that we don't have to hack friendly_id, aasm and will_paginate in. Version
Philip Arndt put a .to_s on the end of this to ensure that the comparison works pr…
Feb 17, 2010
Philip Arndt Fixes javascript problems, notably that jqueryui 1.8 is no longer in …
…the google apis and also fixes the call to the apis (rails is supposed to not put .js on an absolute url but it has been)
Philip Arndt fix a bug when having two editors on one page 0fdd64c
Philip Arndt Send a blank response with 304 4bc77f0
Philip Arndt Got the etags under control and now using a Rack::Static like impleme…
…ntation using Rack::File (thanks to wycats for prodding in the right direction)
Feb 18, 2010
Philip Arndt get rid of some code smells and complexities 7ea0b63
Feb 19, 2010
David Jones first functional test in. login_as test helper setup to make it easy …
…to log a user in and start testing Refinery itself
David Jones added instructions explaining how to run the tests 0a435b5
Feb 23, 2010
Removed double confirmation, just let jQuery handle it 017c441
=~ method for path names is deprecated in Ruby >1.9 2d8c3b2
Philip Arndt do more to ensure that paths are unique before saving them to global …
…variable or adding them to the load path.
Philip Arndt Refinery.root wasn't being set properly because while the pathname wa…
…s blank it was still a pathname.. Now we check for length.
Philip Arndt Refactor the way that Refinery figures our paths and add messages and…
… documentation for these processes.
Philip Arndt cleanpath 81329cb
Philip Arndt decouple themes from the main application some more 266c848
Philip Arndt Fix bug that was introduced that threw out page ordering in the menu f297010
Perform .to_s on title before trying to truncate to prevent error fd98bd2
Philip Arndt Fix password reset code c928865
Feb 24, 2010
Philip Arndt forcibly reject user from plugins that they can't access because they…
… don't have permission.
Philip Arndt Support slim_scrooge version 1.0.5 and above as sdsykes has made this…
… work cross-platform now so we don't have to exclude Windows (thanks to sdsykes)
Philip Arndt Fix problems that people were having installing/updating gems. Please…
… update to version 1.3.6 of rubygems by typing: gem update --system
Philip Arndt Remove Theme support UI but leave in Theme support. Now it's set by t…
…he developer specifying the theme name in Refinery Settings (We've had a lot of requests to get rid of the UI for this which we do tend to agree with as clients don't really need it). Themes are now hot-swappable EXCEPT for any controllers you have inside there won't be reloaded which may give you some grief unless you restart your webserver after swapping the active theme. This was a necessary caveat unless anyone can figure out how to swap out controllers at runtime?
Philip Arndt We don't need to load in the controller paths unless a theme is speci…
Philip Arndt Just a different description for the version bump task fa9a8a3
Philip Arndt Seems like time for a new version 0664576
Feb 25, 2010
Lee Irving [GitHub#43] BugFix for pageparts d412104
Philip Arndt copy themes directory when installing from gem 0e6de5d
Philip Arndt copy version file too f2d2836
Philip Arndt Rewired how Refinery gets access to its core components when installe…
…d as a gem vs as a clone. This solves some problems that people were having with friendly_id (among other plugins installed via gems) being included by plugins that complained before it was possible to run rake gems:install to fix it.
Philip Arndt encode HTML before substituting in HTML for formatting inquiries 7d468c7
Philip Arndt Be more descriptive as to what's going on when I hit delete and remov…
…e the requirement for PagePart to use has_friendly_id as it wasn't really needed.
Feb 26, 2010
Philip Arndt Refinery now will cache RefinerySetting lookups inside the Rails.cach…
…e and changing the theme will switch to a new fragment cache key for the site menu because the theme name is now appended to the fragment cache key. (thanks stevenheidel for the tip). Also cleaned up whitespace (for some reason there was diff cruft)
David Jones working towards more functional tests bb5822d
David Jones merge 06dcc5c
David Jones testing recent activity and adding in images functional tests 9a47675
David Jones auto login with tests on setup but still allow logout for testing sec…
David Jones tidy up commented out code ad5f338
David Jones better functional image test coverage fcf7c81
David Jones should be an image param not a post param 8f0881e
Feb 27, 2010
Philip Arndt improve the parents list to filter out bad pages e.g. the current pag…
…e or any of its decendants
Philip Arndt Focus first textarea or input type text element inside a dialog when …
…the dialog is opened. Fixes (mostly) issue 44 (
Philip Arndt minor css fixes for IE 03e19fb
Philip Arndt conciseness and type=text works better than text 45e9783
Philip Arndt Got rid of thickbox and converted core dialogs to using jQuery UI's .…
Mar 01, 2010
Philip Arndt Fix themes breaking rake db:setup because RefinerySetting.table_exist…
…s? is false.
Philip Arndt Removed Gemfile & bundler. That can wait until Rails3 integration, ri…
…ght now it is more trouble keeping up than it is worth. Moved a lot of config that is troublesome into refinery core so that we don't have to manage updates. config/application.rb now uses a simpler format (which no doubt will change with Rails3). Added deprecation warnings for constants that have been replaced - REFINERY_ROOT is now Refinery.root and USE_S3_BACKEND is now Refinery.s3_backend
Philip Arndt Added the ability to test the core Refinery project from an installed…
… application (this is applicable if you're running from a gem). To run the Refinery tests use the new command rake test:refinery which runs all unit, functional, integration and performance tests inside Refinery core without having to copy them to the current directory. This is also compatible with having your own tests in your own test directory so you could run rake test && rake test:refinery to have full coverage. rake test:refinery does respond whether you're running from gem or not, however if you're not running a gem then rake test achieves the same goal.
Philip Arndt And then, the moment after committing, I realised that I hadn't inclu…
…ded any of the right paths that would actually make this work (I had been saving the wrong files -- the ones in my test directory). So here they are.
Mar 02, 2010
Philip Arndt Ensure anchor tags can't be navigated to from within the wymeditor do…
Philip Arndt use the shared head for the dialogue layout too because it makes more…
… sense to unify.
Philip Arndt Remove old thickbox code and hook into the ui dialog instead 2c67670
Philip Arndt use new dialogs code 33967f6
Philip Arndt New version addresses issues with the javascript functions 0848b3f
Mar 03, 2010
Philip Arndt fix override task 4ab0baf
Philip Arndt new version 947765a
Philip Arndt Hooks into the image picker API when you script/generate refinery tit…
…le:string image_id:image (for example) i.e. when you specify a field is type 'image' it will set it up as an integer field and create a belongs_to association with the Image model and create an image picker on the backend and display the image using image_fu on the frontend. Fixed a few bugs with the image picker in the process. New Version
Mar 04, 2010
Philip Arndt Don't bold this page 47a1e9d
Luke brown Removed the line that changes the template root for ActionMailer::Bas…
…e, this is no longer needed and causes a template missing error in any app level mailers
Philip Arndt fix whitespace (again?) and reduce friendly_id gem requirement to 2.2…
….2 because this works too and provides greater compatibility with previous releases of Refinery
Philip Arndt Merge branch 'master' of 0e290a1
Philip Arndt support image_submit_tag for themes too 1fe4111
Philip Arndt fix reordering for lists of size greater than ten. 65ef303
Philip Arndt Fix issue #47 with never-showing-up news items and where is this whit…
…espace coming from?
Philip Arndt Improve the generator's usage, readme and migrate message now appears…
… *after* generation is complete
Philip Arndt New Version e87382a
Tyler Rick Ruby 1.9 compatibility fix: add a to_s to the Pathname
Ruby 1.8 allowed Dir["whatever*")] but in Ruby 1.9:

TypeError: can't convert Pathname into String
Tyler Rick Ruby 1.9 compatibility fix for this error:
indexer.rb:18: Invalid next
indexer.rb:22: Invalid next
indexer.rb: compile error (SyntaxError)

This works around upstream issue:
Tyler Rick Fixed minor spelling mistake (set up and log in each require a space
when used as a verb).
Philip Arndt remove news plugin so that it can be an external plugin c742abd
Philip Arndt Document where we would place code and what sort of code to fix Issue #… d1c7dff
Mar 05, 2010
Philip Arndt Further prevent unlikely XSS entry points. Note that no code was actu…
…ally being executed so there was no security risk, but it could have possibly made the display on the dashboard and the email go a tiny bit funny.
Philip Arndt Merge branch 'master' of cd7f479
Philip Arndt gem disabled for now a0e6a7d
Philip Arndt remove auto_discovery_link_tag for now 4d76004
Mar 08, 2010
Philip Arndt Fixes issue #56 where reordering didn't trigger a menu cache expiry. cfffe97
Mar 09, 2010
Philip Arndt Fix Issue #53 where app/views wasn't taking precendence over theme/cu…
…rrent_theme/views. app/views now override all other views which is expected Rails behaviour.
Philip Arndt small refactor 7699d73
Mar 11, 2010
Philip Arndt improve routing and syntax 641d193
Philip Arndt news items shouldn't be here anymore c23635b
Mar 12, 2010
Philip Arndt Make friendly_id a plugin rather than relying on a gem which seems to…
… always cause users problems.
Philip Arndt require refinerycms-news 0.9.7 c51e193
Philip Arndt update .gems file for heroku (thanks unixcharles) 86e197d
Philip Arndt Update instructions to explain how to use the news engine fa3a389
Philip Arndt update news link to new repository 035a72d
Philip Arndt Remove gem dependencies and install these packages as vendor/plugins …
…of Refinery core instead. This should save a lot of people a lot of grief.
Philip Arndt Removed act as state machine - we don't really need it. d322a8b
Tyler Rick Added config.log_level = :debug to config/environments/development.rb fc70bfb
Tyler Rick Set config.reload_plugins = true because that would make things less
tedious so we don't have to restart the server every time we change a
controller in a plugin.
Tyler Rick Changed authentication plugin to use Authlogic instead of

This makes it possible for people to integrate Refinery into apps that
are already using Authlogic for authentication.

For those who were using Refinery's default (restful_authentication),
this change shouldn't affect you either. Authlogic's
act_like_restful_authentication = true option means that users should
still be able to log in even though their passwords were encrypted with
restful_authentication. The transition_from_restful_authentication
option means that "every time a user successfully logs in and their
password is encrypted with the restful_authentication algorithm it will
update their password with the Authlogic algorithm. When a new account
is created it will use the Authlogic algorithm. This allows your user
base to slowly transition and allowing them to still be able to log in."

The User model is also a lot simpler now, since most of the authentication
code is handled in the Authlogic gem itself. This leaves the model so
that it only needs to worry about application-specific stuff.
Tyler Rick Removed unused columns generated by restful authentication.
(See also 96c28c5)
Tyler Rick Commented which methods in app/models/user.rb we can probably get rid of
if we switch from restful_authentication to authlogic.
Philip Arndt implement support for recent changes 4c4abad
Tyler Rick Made it so that users can by default log in with either their login or
their e-mail address, since this is a common and easy mistake to make.

Added a 'login_field' setting that allows you to ask for e-mail address
instead of login (the default) on the login page.

This setting wouldn't have worked to be stored in the database, so I
simply added a class accessor method to RefinerySetting.
Philip Arndt Implement the login_field setting on the Refinery module as authentic…
…ation_login_field instead of the RefinerySetting model, which reduces coupling. Also it provides a nice example of how plugin developers could create their own settings using Refinery module. Added a new file config/settings.rb to allow these settings to be changed per-app.
Philip Arndt Make tests work with the new authlogic regime 903c8af
Philip Arndt Update link to portfolio gem e0225ad
Mar 15, 2010
Alex Coles Authlogic (with SQLite3): Make two db columns nullable
* Should un-break tests for both master (Rails 2.3) and rails3 branch.

Signed-off-by: Alex Coles <>
Tyler Rick One more place where RefinerySetting.login_field needed to be changed to
Tyler Rick Fix a bug where it would always say "Logged in successfully" even when
they weren't logged in successfully.

Somewhat confusingly, UserSession.create is not the same as UserSession.create will return a UserSession
object (such #<UserSession: no credentials provided>), even if there was
an authentication error. This changes it back to use save, which returns
true or false.
Tyler Rick The name of the text_field needs to match the name set as the
login_field in UserSession or we will get "undefined method a `login'
for #<UserSession: no credentials provided>" error when
Refinery.authentication_login_field is set to 'email'.
Tyler Rick Changed the error message to read "Sorry, your email or password was …

if they are using Refinery.authentication_login_field = 'email'.
Tyler Rick Added a warning for users who are integrating Refinery into an existing
app that has an Authlogic-created users table.
Philip Arndt Default login field is login to keep standard with how it's always been 1e6689e
Philip Arndt It's now possible to opt-out of the IE6 upgrade message, but please d…
…on't unless your site is fully compliant as we're really hoping that users will see it and upgrade.
Philip Arndt Welcome back, tooltips. e33afa3
Philip Arndt rendering tweaks to improve loading across browsers c97c559
Mar 16, 2010
Philip Arndt Add authlogic as a plugin and only run the acts_as_authentic block if…
… the table has been created already (this allows rake db:setup to work).
Philip Arndt Load authlogic before other plugins and set users to active when crea…
…ting them.
Philip Arndt Try to use title first but if title is missing use tooltip (which we …
Mar 17, 2010
David Jones add analytics to github e46655b
David Jones turns out github doesn't let you put JS in place d540527
Philip Arndt Update slim_scrooge to work as a plugin e1f3e41
Philip Arndt We no longer use authlogic as a gem but as a plugin 7dd4c88
Philip Arndt Merge branch 'master' of 56cf219
Philip Arndt Remove state from users. Tests are still inexplicably failing. bacb704
Alex Coles Fix functional tests to work with Authlogic
* Update fixtures to include persistence_token and setup authlogic test
  helpers correctly.

Signed-off-by: Alex Coles <>
Mar 18, 2010
David Jones formatting improvement c744b57
Philip Arndt update slim scrooge to dynamically figure out makefile stuff and igno…
…re these files.
Philip Arndt Merge branch 'master' of acc4ade
Philip Arndt fix whitespace a7822ac
Philip Arndt update to latest version of parndt/slim_scrooge 095ac3f
David Jones keep a centralised method for the cache key 4043cd5
David Jones tidying up things a little with the themes. 0b63e1c
David Jones tidied up themes some more 1ef2937
David Jones required option just incase someone wants to override the way themes …
…are selected, they can get all the environment info too to help them make that decision
Mar 19, 2010
Philip Arndt Provide an opportunity to inject code after the javascript libraries …
…are included but before any other libraries are included.

This is useful for example when you want to supply custom_wymeditor_boot_options (say you wanted to specify the translation that wymeditor's using, that sort of thing).

Use it like in this example: <% content_for :head_after_javascript_libraries do %><%= javascript_include_tag '/shared/admin/my_javascript_options' %><% end %>
Philip Arndt Update to latest version of slim_scrooge (thanks sdsykes) 9efbd21
David Jones refactored load order for working out the current theme. Also save se…
…tting without bang
David Jones Merge branch 'master' of 5339816
David Jones merge e1b5601
Mar 20, 2010
Philip Arndt prepare for next vesion (not necessarily coming any time soon) 0557994
Philip Arndt Merge branch 'master' of 25b4373
Mar 21, 2010
Charles Barbier add resource field type support to generator c7a80f3
Mar 22, 2010
Philip Arndt copy the new settings file if it doesn't exist yet ea5314f
Philip Arndt Merge branch 'master' of git:// b5fffc0
Philip Arndt comment out differently fef9102
Philip Arndt RegExp matching here instead 3e9733e
Philip Arndt Better tooltip code. Now you can apply tooltips to spans using title=…
…'hello world' or you can apply them to anything using tooltip='hello world' (for example)
Mar 23, 2010
Philip Arndt Upgrade jquery && jquery ui. If you want this to be handled automatic…
…ally in your sites, make sure you include then with <%= jquery_include_tags %> as that's something we will handle on each upgrade.
Philip Arndt fix ordering in parents list db78a31
Philip Arndt update task now keeps jquery up to date 78e92af
Mar 25, 2010
Philip Arndt allow override of button text 9bc6e01
Philip Arndt pesky d059ea1
Mar 26, 2010
David Jones fixed bug that caused rake tasks running twice from plugins in the ve…
…ndor directory
Mar 27, 2010
Philip Arndt adds some improvements and removes some annoyances. c4ade23
Philip Arndt updated yardopts and remove this plugin until it can be included cleanly d93fbc7
Philip Arndt new version (yeah, the last one lasted about 5 minutes, so what) 4aca120
Philip Arndt Get rid of the last trace of news and clean up some whitespace (pleas…
…e look the other way while we release another version) ;)
Mar 29, 2010
Philip Arndt Fix calling method but not providing the parameter required. 8798be5
Philip Arndt Fix for 1.9.x (Thanks to Nikolay for pointin…
…g this out)
Mar 30, 2010
Do not show blank password hint when creating a new user b429bf2
Philip Arndt include line break in conditional too a68eda8
Apr 01, 2010
Philip Arndt add default favicon.ico 663293e
Apr 02, 2010
Philip Arndt Updated version 78127d6
Philip Arndt This should have been how we always did it, I mean, we delete them al…
…l on line 42 so why find_or_create when we know they're gone? Also adds position.
Apr 06, 2010
Philip Arndt Fix pathname because of different interface in 1.9.x 0814577
Andrew Vit doc typo 720c7a4
Andrew Vit Changed to use Presenter for title information 78001bd
Apr 08, 2010
Philip Arndt fix spelling 6cbffd4
Philip Arndt don't titleize the site name and open the insert dialog with :modal t…
…rue instead of :dialog true. Fixes Issue #65
Philip Arndt new version 4f94aac
Apr 13, 2010
Amanda Wagener Links in dialogs no longer open in dialogs 17d7149
Andrew Vit Flash should only be set after the mailer action succeeds. 38f45dc
Andrew Vit Prevent migration failure when changing null reset_code column. e00a39f
Philip Arndt new version with fix for core functionalities 7d0dec4
Philip Arndt support more presenter paths and add custom_title_type to the pages p…
Apr 14, 2010
Philip Arndt Just a change to the backend branding dates, disabled by default. e8dda49
Philip Arndt doesn't seem like we use these methods anywhere and password encrypti…
…on works without them.
Philip Arndt Lay out HTML properly and use :collection with render partial instead…
… of @collection.each render partial.
Philip Arndt added route to /contact which goes to inquiries/new - let us know if …
…you disagree
Philip Arndt Don't titleize here either 940d527
Philip Arndt rip out caching, it doesn't save us anything on production really whi…
…ch is when this matters, not worth the hassle.
Philip Arndt setting won't always be found so return only if it is c443fdd
Apr 15, 2010
Philip Arndt Give some love to seeds and the process around creating the first use…
…r. Now the first user gets inquiries sent to their email address rather than this being a blank field by default. New version.
Philip Arndt prevent images overflowing and taking over the document, when the ima…
…ges are not set to the right size through not being able to be thumbnailed or some other reason.
Philip Arndt ensure that we use the actual refinery setting here. 7aeffd8
Philip Arndt improve syntax eb29e8d
Philip Arndt another whitespace 5ceb926
Apr 16, 2010
Philip Arndt we're in your controllers, protecting you from 500s 8792d24
Philip Arndt Updated version c2ea042
Apr 20, 2010
David Jones updating docs to reflect the use of authlogic now and not restful aut…
Philip Arndt Better paste support for browsers other than safari (maybe IE too). D…
…efinitely gecko.
Philip Arndt Merge branch 'master' of 261450f
Philip Arndt new version 72448fc
Apr 30, 2010
Philip Arndt See contributors here 6355889
Philip Arndt split up the form partial into 4 partials for easier overriding but n…
…ot done on this refactor yet.
Philip Arndt mild refactor 203f7b9
Philip Arndt nothing really f37ade3
May 02, 2010
Philip Arndt change file path to the actual file. fe1e91e
May 03, 2010
David Jones remove open/closed inquiry functionality. And replace with inquiries …
…simply ordered by the day they came in.
David Jones Merge branch 'master' of 4604c1d
David Jones remove old test d63a0c3
Philip Arndt update acts_as_indexed to parndt forked version to fix an exception f…
…ound while running in production mode and fix whitespace.
Philip Arndt Merge branch 'master' of 74778b3
May 04, 2010
Philip Arndt merge in changes from acts_as_indexed master 26e9803
Philip Arndt Put privacy policy page underneath contact us page 3389b7a
Philip Arndt Add flexibility to be able to pass in another collection (of pages at…
… this stage) to the menu
Philip Arndt This is not an SEO option 558e30d
Philip Arndt Fix down for maintenance by loading the menu's pages. 9051cca
May 05, 2010
Josiah Ivey Fix typo in readme dd12efc
May 06, 2010
Philip Arndt Don't need to scan thumbnails if the thumbnail required is nil 96e9baa
Philip Arndt Merge branch 'master' of c7fe8ab
Philip Arndt Documentation -- also a new argument for jquery_include_tags for goog…
…le ajax stuff
Philip Arndt Prettify things a bit 27c6060
Philip Arndt change another image and make the update task update more files 93d3a2c
Philip Arndt Tiny bit of a UI update. Tabs are now rounded at the top and look mor…
…e like tabs.
Philip Arndt About time we had another small release, don't you think? 250a2fa
Philip Arndt Fix problems identified when testing gem installation, more files nee…
…ded updating.
May 07, 2010
David Jones contributors file is gone so stop yard from warning about a missing f…
…ile when installing the gems
Philip Arndt no longer exists and shouldn't be copied. 82c9df1
Philip Arndt Merge branch 'master' of df4eae8
Philip Arndt Increment version 4542464
Philip Arndt fix typo, remove toggle_status route which is not used anymore. 877d283
May 08, 2010
David Jones updating todos f392a17
David Jones Merge branch 'master' of fd8d95b
May 10, 2010
David Jones Added site bar to switch between live and editor views. Small UI tweaks 4018fe5
Philip Arndt Fix a few places that didn't agree with the new ui e.g. edit screens. 056fbfe
Philip Arndt yield order playing up cc1feb6
Philip Arndt More tweaks to ui, increased number of settings displayed. HTML5 on b…
…ackend now.
Philip Arndt nicer padding 1180e2a
Philip Arndt You all can use HTML5 too a07b5d2
Philip Arndt New version, not long until 0.9.7 d6a644a