Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Not redirected after login #1561

Closed
parndt opened this Issue · 8 comments

4 participants

Philip Arndt Josef Šimánek Uģis Ozols Alexander Wenzowski
Philip Arndt
Owner

When I go to a URL say http://localhost:3000/refinery/pages/home/edit but need to login I do so and am taken to the dashboard. This is not correct and I should be taken to the edit action for the 'home' page.

Josef Šimánek
Collaborator

@parndt this works for me. I'm not redirected to dashboard.

Philip Arndt
Owner

@simi Weird; thanks. Wonder why it happens to me..

Uģis Ozols
Owner

I can reproduce.

Philip Arndt
Owner
Uģis Ozols
Owner

Nope, it just doesn't work.

Philip Arndt
Owner

OK. I don't think we should devote any time to this until authentication has been split out. It's likely we'll solve this accidentally during the process of defining authentication interaction APIs for Refinery <-> Authentication

Philip Arndt parndt closed this
Alexander Wenzowski

At first glance, I would assume the issue is related to the fact that store_location is creating an unscoped session key, and that this unscoped key is not being explicitly checked in after_sign_in_path_for.

If I understand the devise default correctly, it should be looking for the "#{scope}_return_to" key. At least that's what the docs seem to indicate.

Alexander Wenzowski wenzowski referenced this issue from a commit in wenzowski/refinerycms
Alexander Wenzowski wenzowski authentication redirection improvement #1724
- add tests for #1561 behaviour
- use unscoped session key to enable store_location to be used for login #1724
47dde82
Alexander Wenzowski wenzowski referenced this issue from a commit in wenzowski/refinerycms
Alexander Wenzowski wenzowski added #1561 and #1728 bugfixes to change log 1987f58
Alexander Wenzowski wenzowski referenced this issue from a commit in wenzowski/refinerycms
Alexander Wenzowski wenzowski authentication redirection bugfix #1561
Fixed and added tests for post-authentication redirect bug where users would always be redirected to the admin root after successful auth.
347b784
Alexander Wenzowski

Previous patch split into:

Previous pull request code closed and bad patch deleted.

New pull request opened.

Ole Reifschneider Tranquility referenced this issue from a commit
Alexander Wenzowski wenzowski Authentication redirection bug-fix which fixes #1561
* Fixed post-authentication redirect bug where users would
  always be redirected to the admin root after successful auth.
* Added tests for proper functionality.
0b3b7a2
Jean-Philippe Boily jipiboily referenced this issue from a commit in jipiboily/refinerycms
Alexander Wenzowski wenzowski Authentication redirection bug-fix which fixes #1561
* Fixed post-authentication redirect bug where users would
  always be redirected to the admin root after successful auth.
* Added tests for proper functionality.
7b5d27b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.