Not redirected after login #1561

Closed
parndt opened this Issue Apr 4, 2012 · 8 comments

Projects

None yet

4 participants

@parndt
Owner
parndt commented Apr 4, 2012

When I go to a URL say http://localhost:3000/refinery/pages/home/edit but need to login I do so and am taken to the dashboard. This is not correct and I should be taken to the edit action for the 'home' page.

Member
simi commented Apr 8, 2012

@parndt this works for me. I'm not redirected to dashboard.

Owner
parndt commented Apr 8, 2012

@simi Weird; thanks. Wonder why it happens to me..

Owner

I can reproduce.

Owner
parndt commented May 17, 2012

@ugisozols yay! Any special steps required?

Owner

Nope, it just doesn't work.

Owner
parndt commented May 18, 2012

OK. I don't think we should devote any time to this until authentication has been split out. It's likely we'll solve this accidentally during the process of defining authentication interaction APIs for Refinery <-> Authentication

@parndt parndt closed this May 18, 2012
Contributor

At first glance, I would assume the issue is related to the fact that store_location is creating an unscoped session key, and that this unscoped key is not being explicitly checked in after_sign_in_path_for.

If I understand the devise default correctly, it should be looking for the "#{scope}_return_to" key. At least that's what the docs seem to indicate.

@wenzowski wenzowski added a commit to wenzowski/refinerycms that referenced this issue Jun 4, 2012
@wenzowski wenzowski authentication redirection improvement #1724
- add tests for #1561 behaviour
- use unscoped session key to enable store_location to be used for login #1724
47dde82
@wenzowski wenzowski added a commit to wenzowski/refinerycms that referenced this issue Jun 4, 2012
@wenzowski wenzowski added #1561 and #1728 bugfixes to change log 1987f58
@wenzowski wenzowski added a commit to wenzowski/refinerycms that referenced this issue Jun 5, 2012
@wenzowski wenzowski authentication redirection bugfix #1561
Fixed and added tests for post-authentication redirect bug where users would always be redirected to the admin root after successful auth.
347b784
Contributor

Previous patch split into:

Previous pull request code closed and bad patch deleted.

New pull request opened.

@jipiboily jipiboily pushed a commit to jipiboily/refinerycms that referenced this issue Jun 9, 2012
@wenzowski @parndt wenzowski + parndt Authentication redirection bug-fix which fixes #1561
* Fixed post-authentication redirect bug where users would
  always be redirected to the admin root after successful auth.
* Added tests for proper functionality.
7b5d27b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment