wymeditor offsite links fail silently unless focus is moved off field #901

Closed
Anatortoise opened this Issue Aug 22, 2011 · 4 comments

Comments

Projects
None yet
2 participants
@Anatortoise
Contributor

Anatortoise commented Aug 22, 2011

Easiest reproduction of issue:

Go to:

http://demo.refinerycms.com/refinery/pages/new

Enter your title, and a body like "Put yer link here."

Highlight "here", hit "Add Link" button in Wymeditor, choose "Website" radio choice, enter "http://www.refinerycms.com", don't change focus from that field, just press "Insert".

Dialog is dismissed, html tab shows no anchor links created, no change to text.

Follow same process, but tab away from the field after entering the website triggers a validiation (not sure if its ajax or client side), which puts up either a green check or red x icon next to the field. Then click "Insert" and the link is (often) successfully created. Note, the link will be created even if the red x icon is presented. Not sure if that is by design or not.

@ugisozols

This comment has been minimized.

Show comment
Hide comment
@ugisozols

ugisozols Aug 23, 2011

Member

Just a quick note - I can't reproduce it on master.

Member

ugisozols commented Aug 23, 2011

Just a quick note - I can't reproduce it on master.

@ugisozols ugisozols closed this in 0421b86 Aug 23, 2011

@ugisozols

This comment has been minimized.

Show comment
Hide comment
@ugisozols

ugisozols Aug 23, 2011

Member

I just merged my changes from the master into 1-0-stable ;)

Member

ugisozols commented Aug 23, 2011

I just merged my changes from the master into 1-0-stable ;)

@Anatortoise

This comment has been minimized.

Show comment
Hide comment
@Anatortoise

Anatortoise Aug 23, 2011

Contributor

Thanks. Am I correct that those changes would appear in the 1.0.5 set of gems when they become available? (or I could build from a local copy of the 1-0-stable branch..)

Contributor

Anatortoise commented Aug 23, 2011

Thanks. Am I correct that those changes would appear in the 1.0.5 set of gems when they become available? (or I could build from a local copy of the 1-0-stable branch..)

@ugisozols

This comment has been minimized.

Show comment
Hide comment
@ugisozols

ugisozols Aug 23, 2011

Member

Yes, this fix will be in 1.0.5 and if you need it right now you can point to this repo in your Gemfile.

Member

ugisozols commented Aug 23, 2011

Yes, this fix will be in 1.0.5 and if you need it right now you can point to this repo in your Gemfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment