Disable page caching when logged in to prevent caching the sitebar. #1609

Merged
merged 1 commit into from Apr 22, 2012

Conversation

Projects
None yet
3 participants
Contributor

jokklan commented Apr 22, 2012

When cache_pages_full is enabled the page will be cached WITH the blue sitebar if you are logged in.

This commit should fix that.

This pull request passes (merged 707128f into 755f94b).

Owner

parndt commented Apr 22, 2012

Thank you; I think there's a method like refinery_user_signed_in? which might suit this better

Contributor

jokklan commented Apr 22, 2012

There is yes, but in _site_bar.html.erb is the condition the following:

if refinery_user? && "#{controller_name}##{action_name}" != 'pages#preview'

so i thought i would make it the same?

@parndt parndt added a commit that referenced this pull request Apr 22, 2012

@parndt parndt Merge pull request #1609 from TheMaster/patch-1
Disable page caching when logged in to prevent caching the sitebar.
29d4b03

@parndt parndt merged commit 29d4b03 into refinery:master Apr 22, 2012

Owner

parndt commented Apr 22, 2012

Quite true, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment