Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure each engine is included for each generator. #1691

Merged
merged 1 commit into from May 24, 2012

Conversation

@sdownie
Copy link
Contributor

commented May 24, 2012

When excluding an engine in your Gemfile (Example: refinerycms-authentication) and you run rails g refinery:cms --fresh-installation it still attempts to run the generators for the excluded engine.

@travisbot

This comment has been minimized.

Copy link

commented May 24, 2012

This pull request passes (merged 3b5264a into 950f934).

ugisozols added a commit that referenced this pull request May 24, 2012

Merge pull request #1691 from sdownie/engine_generators
Ensure each engine is included for each generator.

@ugisozols ugisozols merged commit 7570926 into refinery:master May 24, 2012

@MadWagon

This comment has been minimized.

Copy link

commented Nov 16, 2012

This merge doesn't seem to be part of current 2-0-stable, was it removed ?

@ugisozols

This comment has been minimized.

Copy link
Member

commented Nov 16, 2012

I think it just wasn't backported... Are you having an issue which this PR solves?

@MadWagon

This comment has been minimized.

Copy link

commented Nov 16, 2012

Yes, I am trying the get rid of the Refinery Authentication (integrating Refinery with an existing app as per the guide) but I can't.

@ugisozols

This comment has been minimized.

Copy link
Member

commented Nov 16, 2012

I cherry picked that commit for 2-0-stable in 7d7aff3 so if you need that fix now you can point refinery's gem to use 2-0-stable branch:

# Gemfile
gem "refinerycms", :git => "git://github.com/refinery/refinerycms.git", :branch => "2-0-stable"
@MadWagon

This comment has been minimized.

Copy link

commented Nov 16, 2012

Good thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.