Skip to content
This repository

Move flag links outside of title span. #1741

Merged
merged 2 commits into from about 2 years ago

3 participants

Uģis Ozols Don't Add Me To Your Organization a.k.a The Travis Bot Philip Arndt
Uģis Ozols
Owner

Until now these links were disabled by expand/collapse stuff.

Fix for https://github.com/parndt/refinerycms-i18n/issues/34

Uģis Ozols ugisozols Move flag links outside of title span.
Until now these links were disabled by expand/collapse stuff.
42d41e0
Uģis Ozols
Owner

I wasn't sure if links should have been wrapped in some kind of or not...

Don't Add Me To Your Organization a.k.a The Travis Bot

This pull request passes (merged 42d41e0 into 10337cb).

Don't Add Me To Your Organization a.k.a The Travis Bot

This pull request passes (merged a7a69b2 into 10337cb).

Philip Arndt parndt merged commit a7a69b2 into from
Philip Arndt parndt closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 2 unique commits by 1 author.

Jun 10, 2012
Uģis Ozols ugisozols Move flag links outside of title span.
Until now these links were disabled by expand/collapse stuff.
42d41e0
Jun 11, 2012
Uģis Ozols ugisozols Wrap flag icons in span. a7a69b2
This page is out of date. Refresh to see the latest.
3  core/app/assets/stylesheets/refinery/layout.css.scss
@@ -230,6 +230,9 @@ a:hover {
230 230 padding: 0px;
231 231 a {
232 232 border-bottom: 1px dotted #727272;
  233 + &.locale {
  234 + border-bottom: 0;
  235 + }
233 236 }
234 237 h1 {
235 238 font-size: 18px;
18 pages/app/views/refinery/admin/pages/_page.html.erb
@@ -8,16 +8,16 @@
8 8
9 9 <span class='title <%= 'toggle' if page.children.present? %>'>
10 10 <%= page.title_with_meta.html_safe %>
11   - <% if Refinery.i18n_enabled? and Refinery::I18n.frontend_locales.many? %>
12   - <span class='preview'>
13   - <% page.translations.each do |translation| %>
14   - <%= link_to refinery_icon_tag("flags/#{translation.locale}.png", :size => '16x11'),
15   - refinery.edit_admin_page_path(page, :switch_locale => translation.locale),
16   - :class => 'locale' if translation.title.present? %>
17   - <% end %>
18   - </span>
19   - <% end %>
20 11 </span>
  12 + <% if Refinery.i18n_enabled? and Refinery::I18n.frontend_locales.many? %>
  13 + <span class='locales'>
  14 + <% page.translations.each do |translation| %>
  15 + <%= link_to refinery_icon_tag("flags/#{translation.locale}.png", :size => '16x11'),
  16 + refinery.edit_admin_page_path(page, :switch_locale => translation.locale),
  17 + :class => 'locale' if translation.title.present? %>
  18 + <% end %>
  19 + </span>
  20 + <% end %>
21 21
22 22 <span class='actions'>
23 23 <%= link_to refinery_icon_tag('application_go.png'),

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.