Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Move flag links outside of title span. #1741

Merged
merged 2 commits into from

3 participants

@ugisozols
Owner

Until now these links were disabled by expand/collapse stuff.

Fix for https://github.com/parndt/refinerycms-i18n/issues/34

@ugisozols ugisozols Move flag links outside of title span.
Until now these links were disabled by expand/collapse stuff.
42d41e0
@ugisozols
Owner

I wasn't sure if links should have been wrapped in some kind of or not...

@travisbot

This pull request passes (merged 42d41e0 into 10337cb).

@travisbot

This pull request passes (merged a7a69b2 into 10337cb).

@parndt parndt merged commit a7a69b2 into from
@ugisozols ugisozols referenced this pull request from a commit
@ugisozols ugisozols Add note to changelog about #1741. 20e80ef
@ugisozols ugisozols referenced this pull request from a commit
@ugisozols ugisozols Add note to changelog about #1741. a869a6c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jun 10, 2012
  1. @ugisozols

    Move flag links outside of title span.

    ugisozols authored
    Until now these links were disabled by expand/collapse stuff.
Commits on Jun 11, 2012
  1. @ugisozols

    Wrap flag icons in span.

    ugisozols authored
This page is out of date. Refresh to see the latest.
View
3  core/app/assets/stylesheets/refinery/layout.css.scss
@@ -230,6 +230,9 @@ a:hover {
padding: 0px;
a {
border-bottom: 1px dotted #727272;
+ &.locale {
+ border-bottom: 0;
+ }
}
h1 {
font-size: 18px;
View
18 pages/app/views/refinery/admin/pages/_page.html.erb
@@ -8,16 +8,16 @@
<span class='title <%= 'toggle' if page.children.present? %>'>
<%= page.title_with_meta.html_safe %>
- <% if Refinery.i18n_enabled? and Refinery::I18n.frontend_locales.many? %>
- <span class='preview'>
- <% page.translations.each do |translation| %>
- <%= link_to refinery_icon_tag("flags/#{translation.locale}.png", :size => '16x11'),
- refinery.edit_admin_page_path(page, :switch_locale => translation.locale),
- :class => 'locale' if translation.title.present? %>
- <% end %>
- </span>
- <% end %>
</span>
+ <% if Refinery.i18n_enabled? and Refinery::I18n.frontend_locales.many? %>
+ <span class='locales'>
+ <% page.translations.each do |translation| %>
+ <%= link_to refinery_icon_tag("flags/#{translation.locale}.png", :size => '16x11'),
+ refinery.edit_admin_page_path(page, :switch_locale => translation.locale),
+ :class => 'locale' if translation.title.present? %>
+ <% end %>
+ </span>
+ <% end %>
<span class='actions'>
<%= link_to refinery_icon_tag('application_go.png'),
Something went wrong with that request. Please try again.