Fixes #1585. #1882

Merged
merged 2 commits into from Aug 15, 2012

Conversation

Projects
None yet
3 participants
@robyurkowski
Contributor

robyurkowski commented Aug 15, 2012

Sorting 11 items without reordering should be a no-op. However, if we sort the array by the given keys—which are strings—this will actually sort the 11th entry after the 2nd (producing an lft of 5, instead of an expected 21).

EDIT: I cannot count.

@robyurkowski

This comment has been minimized.

Show comment
Hide comment
@robyurkowski

robyurkowski Aug 15, 2012

Contributor

This will fix #1585.

Contributor

robyurkowski commented Aug 15, 2012

This will fix #1585.

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Aug 15, 2012

This pull request fails (merged dc36f082 into 5e22bab).

This pull request fails (merged dc36f082 into 5e22bab).

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Aug 15, 2012

This pull request fails (merged 4c85486 into 5e22bab).

This pull request fails (merged 4c85486 into 5e22bab).

@parndt parndt merged commit 4c85486 into master Aug 15, 2012

1 check failed

default The Travis build failed
Details
@parndt

This comment has been minimized.

Show comment
Hide comment
@parndt

parndt Aug 15, 2012

Member

And cherry-picked to 2-0-stable for you.

Member

parndt commented Aug 15, 2012

And cherry-picked to 2-0-stable for you.

robyurkowski added a commit that referenced this pull request Aug 15, 2012

robyurkowski added a commit that referenced this pull request Aug 15, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment