Join GitHub today
Separate Dragonfly from Images and Resources. #3289
Modify Images and Resources to use common Dragonfly 'engine'
Dragonfly can be used for other engines using the same config options as Images/Resources
Dragonfly can be put into a separate gem, but it will be easier to review this change
Thanks @anitagraham for your awesome work!
I like the fact to extract dragonfly from refinery but i think we should go further :
- Should we keep the name
refinerycms-dragonfly? Should not we use a more generic name like
refinerycms-uploader? because if tomorrow i want to use shrine, what happens?
- We should create a new repository with this extract like we did with
refinerycms-authentication-deviseit will keep this repository cleaner :)
I think it'd be good to get this merged and then extract it, in the spirit of getting it happening and not getting it delayed again, what do you think?
Finally had time to go through this line by line - thanks for doing this!
Requested changes made (except one which is the least important, that I missed.)
Next: take it out to a gem.