Handle events efficiently #4

Closed
spoike opened this Issue Jul 28, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@spoike
Member

spoike commented Jul 28, 2014

Getting this warning message from EventEmitter when creating a lot of stores and actions.

(node) warning: possible EventEmitter memory leak detected. 11 listeners added. Use emitter.setMaxListeners() to increase limit.

Need to rewrite event handling a bit, since for larger web applications there will be a lot of event emitters around so this warning is not very interesting to have.

@spoike spoike added the bug label Jul 28, 2014

@spoike spoike changed the title from Handle action events efficiently to Handle events efficiently Jul 28, 2014

@spoike spoike added this to the 0.1.2 milestone Jul 28, 2014

@dashed

This comment has been minimized.

Show comment
Hide comment
@dashed

dashed Jul 28, 2014

Contributor

Might I suggest a leaner EventEmitter? https://github.com/3rd-Eden/EventEmitter3

Contributor

dashed commented Jul 28, 2014

Might I suggest a leaner EventEmitter? https://github.com/3rd-Eden/EventEmitter3

@dashed

This comment has been minimized.

Show comment
Hide comment
@dashed

dashed Jul 28, 2014

Contributor

Also, allow anyone to pass in their favourite EventEmitter (node, userland, etc) implementation is a plus.

Contributor

dashed commented Jul 28, 2014

Also, allow anyone to pass in their favourite EventEmitter (node, userland, etc) implementation is a plus.

@spoike

This comment has been minimized.

Show comment
Hide comment
@spoike

spoike Jul 28, 2014

Member

Thanks for the tip on EventEmitter3 @dashed. Sounds like this is just what this project needs.

I'll try to expose the EventEmitter so it may be changed/monkey patched to another implementation if the user want's to.

Member

spoike commented Jul 28, 2014

Thanks for the tip on EventEmitter3 @dashed. Sounds like this is just what this project needs.

I'll try to expose the EventEmitter so it may be changed/monkey patched to another implementation if the user want's to.

@spoike spoike closed this in d76f957 Jul 28, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment