Get default data #49

Merged
merged 6 commits into from Aug 20, 2014

Conversation

Projects
None yet
3 participants
@undoZen
Contributor

undoZen commented Aug 18, 2014

Just picked up from where @SimonDegraeve left on #46 . Fix bug and add tests.
Also, add two test cases for stores listen to other stores.

@SimonDegraeve

This comment has been minimized.

Show comment
Hide comment
@SimonDegraeve

SimonDegraeve Aug 19, 2014

Contributor

Nice job. I have been buzy looking deeper into yahoo's dispatchr, fetchr and routr and like you said in this comment the dehydrate/rehydrate feature is quiet awesome.

Appreciate you fix this PR.

Contributor

SimonDegraeve commented Aug 19, 2014

Nice job. I have been buzy looking deeper into yahoo's dispatchr, fetchr and routr and like you said in this comment the dehydrate/rehydrate feature is quiet awesome.

Appreciate you fix this PR.

@SimonDegraeve

This comment has been minimized.

Show comment
Hide comment
@SimonDegraeve

SimonDegraeve Aug 19, 2014

Contributor

Also it would be nice to handle the defaultCallback in createStore and ListenerMixin in a same module (see explanations)

Contributor

SimonDegraeve commented Aug 19, 2014

Also it would be nice to handle the defaultCallback in createStore and ListenerMixin in a same module (see explanations)

@undoZen

This comment has been minimized.

Show comment
Hide comment
@undoZen

undoZen Aug 19, 2014

Contributor

All done. @spoike please review and merge it.

Contributor

undoZen commented Aug 19, 2014

All done. @spoike please review and merge it.

@spoike spoike added this to the 0.1.7 milestone Aug 20, 2014

@spoike

This comment has been minimized.

Show comment
Hide comment
@spoike

spoike Aug 20, 2014

Member

This needs to be documented in the README.md. I'll try to merge this in the evening after work (around 19:00Z+02:00), to make the 0.1.7 release. Feel free to add a blurb about it if @undoZen or @SimonDegraeve has time to do so. :-)

Member

spoike commented Aug 20, 2014

This needs to be documented in the README.md. I'll try to merge this in the evening after work (around 19:00Z+02:00), to make the 0.1.7 release. Feel free to add a blurb about it if @undoZen or @SimonDegraeve has time to do so. :-)

@spoike

This comment has been minimized.

Show comment
Hide comment
@spoike

spoike Aug 20, 2014

Member

Four test cases in testling fail with the following error message:

TypeError: 'undefined' is not a function (evaluating 'defaultCallback.bind(listener)')

They fail because the solution is using Function.prototype.bind which is not available on all browsers.

Member

spoike commented Aug 20, 2014

Four test cases in testling fail with the following error message:

TypeError: 'undefined' is not a function (evaluating 'defaultCallback.bind(listener)')

They fail because the solution is using Function.prototype.bind which is not available on all browsers.

@spoike

This comment has been minimized.

Show comment
Hide comment
@spoike

spoike Aug 20, 2014

Member

I've changed it for the 0.1.7 merge to use Function.prototype.apply and Function.prototype.call instead.

Member

spoike commented Aug 20, 2014

I've changed it for the 0.1.7 merge to use Function.prototype.apply and Function.prototype.call instead.

@spoike spoike merged commit af860bb into reflux:master Aug 20, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment