-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] ? StatusRequestV2Extension #246
Comments
Good catch. I agree that this is a bug. Would you love to submit a pull request addressing this issue? We did not implement enough testcases to cover all the extensions, and I basically reversed the |
Yea that's not a problem, unsure why ReadUint16LengthPrefixed reads the last element tho,,, as there should be one more read left... I'll look into that (unless it treating it as \0) |
Can you be more specific on that? Like, which bytes are you referring to as the last element? |
with the last
|
When you call |
ah right , my bad |
Ran into a situation when using raw bytes, are we sure this was written correctly?
Shouldn't this
read more like...
extData
becomes empty after the firstReadUint16LengthPrefixed
... so you should traverseignored
after that...Example
The text was updated successfully, but these errors were encountered: