Automatically check coding style

[vkarak]

I suggest adding a commit hook that would disable committing if the changed files do not follow the coding style. The downside is that this requires us to have pycodestyle installed on the machine that we commit.

@eth-cscs/reframe-devteam What do you think?

[teojgo]

We can make the travis CI do that without having to install something. Just a pip is needed.

[teojgo]

I have played a little bit with travis regarding this issue. In travis you cannot have independent tabs showing for the pull request. Thus the pycodestyle check would have to be added in the script step. Maybe the situation changes with the Build Stages feature which is currently in beta.

[vkarak]

@teojgo Thanks for investigating. IMHO, even build stages are not what we want ideally, cos we do not want to the whole CI to fail just because of the coding style. Anyway, we freeze this issue for the moment.

[teojgo]

After a more thorough search, it seems that the following github app does what we want: https://github.com/OrkoHunter/pep8speaks. It offers configuration options regarding the pep8 rules to ignore via a .yml file resting in the repo.