[test] Fix nvidia and libsci/mkl resolve tests #1011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The flag for tracing the symbol when linking does not produce any output when xalt 2.7.10 is loaded, thus we used readlef.
vkarak
reviewed
Oct 25, 2019
vkarak
requested changes
Oct 25, 2019
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
lgtm. Just remove the obsolete comment that I have pointed out.
vkarak
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1011 +/- ##
==========================================
- Coverage 91.86% 91.84% -0.02%
==========================================
Files 80 80
Lines 10734 10734
==========================================
- Hits 9861 9859 -2
- Misses 873 875 +2
Continue to review full report at Codecov.
|
vkarak
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
output when xalt 2.7.10 is loaded, thus we used readelf.
Fixes MAINT-210, MAINT-216.