[feat] Renamemake_deferrable() to defer() and make it publicly available along with evaluate()
#1050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `make_deferrable()` is renamed to `defer()` and is moved inside `reframe.utility.sanity`. - `evaluate()` is moved inside `reframe.utility.sanity` - The old functions are deprecated. - Functions are now publicly visible and documentation is updated. - Tests that were making use of them are adapted.
|
Hello @vkarak, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2019-11-22 09:42:50 UTC |
vkarak
changed the title
make_deferrable() to defer() and make it publicly available along with evaluate()
Codecov Report
@@ Coverage Diff @@
## master #1050 +/- ##
==========================================
- Coverage 91.97% 91.97% -0.01%
==========================================
Files 81 81
Lines 10984 10982 -2
==========================================
- Hits 10103 10101 -2
Misses 881 881
Continue to review full report at Codecov.
|
teojgo
requested changes
Nov 19, 2019
reframe/utility/sanity.py
Outdated
| This decorator is an alias to the :func:`reframe.core.deferrable.deferrable` | ||
| decorator. | ||
| The following function definition is equivalent to the above: | ||
| <The following function definition is equivalent to the above: |
teojgo
approved these changes
Nov 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make_deferrable()is renamed todefer()and is moved insidereframe.utility.sanity.evaluate()is moved insidereframe.utility.sanityFixes #1038.