[bugfix] Ignore invalid Slurm nodes in flexible task allocation #1054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Separate the retrieval of Slurm node descriptions and creation of `SlurmNode` instances when getting all nodes in flexible task allocation. * Make the necessary unittests changes to test for invalid node descriptions.
teojgo
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1054 +/- ##
==========================================
+ Coverage 91.97% 92.02% +0.05%
==========================================
Files 81 81
Lines 10975 10975
==========================================
+ Hits 10094 10100 +6
+ Misses 881 875 -6
Continue to review full report at Codecov.
|
vkarak
requested changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate the retrieval of Slurm node descriptions and
creation of
SlurmNodeinstances when nodesin flexible task allocation.
Make the necessary unittests changes to test for invalid
node descriptions.
Fixes #1031