Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Nov 23, 2019

Fixes #1017.

@codecov-io
Copy link

codecov-io commented Nov 23, 2019

Codecov Report

Merging #1067 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1067      +/-   ##
=========================================
+ Coverage   91.69%   91.7%   +<.01%     
=========================================
  Files          81      81              
  Lines       11103   11110       +7     
=========================================
+ Hits        10181   10188       +7     
  Misses        922     922
Impacted Files Coverage Δ
reframe/core/launchers/mpi.py 98.59% <100%> (+0.15%) ⬆️
unittests/test_launchers.py 93.51% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b78150...f28a1e3. Read the comment docs.

@vkarak
Copy link
Contributor Author

vkarak commented Nov 25, 2019

@jgphpc Can you test that on Tiger?

@vkarak vkarak changed the title Emit job options to aprun command line [feat] Emit job options to aprun command line Nov 25, 2019
@vkarak
Copy link
Contributor Author

vkarak commented Dec 3, 2019

As suggested by @TheOneTrueScud, I should change the name of the launcher backend to aprun so as to match documentation + it feels more natural.

Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak
Copy link
Contributor Author

vkarak commented Dec 5, 2019

I will eventually not change the name of the scheduler. The documentation is correct. The aprun vs. alps was just an error in our private communications.

@vkarak vkarak merged commit c1a5917 into reframe-hpc:master Dec 5, 2019
@vkarak vkarak deleted the feat/alps-launcher branch December 5, 2019 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Cray ALPS support

3 participants