-
Notifications
You must be signed in to change notification settings - Fork 117
[feat] Change time_limit attribute to a string-based format
#1142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @rsarm, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2020-02-21 12:28:30 UTC |
Codecov Report
@@ Coverage Diff @@
## master #1142 +/- ##
=========================================
Coverage ? 91.78%
=========================================
Files ? 81
Lines ? 11391
Branches ? 0
=========================================
Hits ? 10455
Misses ? 936
Partials ? 0
Continue to review full report at Codecov.
|
time_limit format to a string-based format
time_limit format to a string-based formattime_limit attribute to a string-based format
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old syntax should not be abolished, but deprecated instead. You will need also a unit test to check that a deprecation warning is raised. If we merge this as it is now, it will break several tests.
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just only some final minor suggestions.
|
@rsarm You'd need also to fix the conflicts before we merge. |
The current format to create
TimerFieldobjects is with a tuple(hours, minutes, seconds).The PR changes the format to a string like
'1d10h30m2s', where 'd', 'h', 'm' and 's' stand for days, hours, minutes and seconds. Simpler strings can be used as'1d'or'1h30m'.Closes #1106