[test] Update tests with the new syntax using decorators #1160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @ekouts, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2020-02-21 13:10:46 UTC |
ekouts
changed the title
vkarak
changed the title
Contributor
|
@victorusu I suggest pushing the tests to change in this PR directly. |
vkarak
requested changes
Feb 14, 2020
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
We need to fix all the tests in this PR. I guess that @victorusu can also push to this branch. @ekouts I have changed the description of your PR and made your points checkboxes. Please check the tests that have been fixed.
Contributor
|
@ekouts Please merge with the master to get the latest changes on the tests and resolve any conflicts. |
Contributor
Update 'apps' checks to new syntax
Contributor
Author
… into check/update_syntax
vkarak
changed the title
Contributor
|
I removed the WIP tag. |
vkarak
requested changes
Feb 21, 2020
…ck/update_syntax
… into check/update_syntax
vkarak
requested changes
Feb 21, 2020
Contributor
|
I think the CI was blocked due to #1083. I will rerun. |
Contributor
|
@jenkins-cscs retry daint |
Contributor
|
@jenkins-cscs retry daint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating tests with the new syntax using decorators in directories:
analytics/productiontag fromSparkAnalyticsChecksince the analytics module is no longer in the systemapps/compile/cuda/libraries/Stencil8HPXCheckhad a typo in thevalid_systemsand it was not running on daintGridToolsCheckis going to be fixed in [test] Fix GridTools test failures on Dom #1181mch/microbenchmarks/HPCGCheckRefandHPCGCheckMKL: UES-735prgenv/system/tools/ioFixes #1131.