[bugfix] Execute setup hooks for CompileOnlyRegressionTest and make the run hooks for the RunOnlyRegressionTest execute at the right place

[ekouts]

Fix CompileOnlyRegressionTest setup hooks.

• Fix should be simple for the setup hooks, I just also need to find where to add a unittest for that.
• The pre_run hook in RunOnlyRegressionTest is not called exactly before the run but only because there is a call to the base class function.
• Finally I don't know if we want the hooks to be called in no-op functions, like the run in CompileOnlyRegressionTest. With the current implementation they won't be called.

Fixes issue #1162.

[ekouts]

@jenkins-cscs retry tsa

[vkarak]

We will need a unit test and a fix for the run() of the run only tests. But this is not blocking us for the moment, so we can push it to the next sprint.

[codecov-io]

Codecov Report

Merging #1163 into master will decrease coverage by 0.01%.
The diff coverage is 97.59%.

@@            Coverage Diff             @@
##           master    #1163      +/-   ##
==========================================
- Coverage   92.17%   92.15%   -0.02%     
==========================================
  Files          81       81              
  Lines       12001    12074      +73     
==========================================
+ Hits        11062    11127      +65     
- Misses        939      947       +8

Impacted Files	Coverage Δ
reframe/core/runtime.py	89.69% <ø> (ø)	⬆️
unittests/resources/checks/frontend_checks.py	99.21% <ø> (ø)	⬆️
reframe/core/launchers/registry.py	85% <ø> (ø)	⬆️
unittests/resources/checks/bad/noentry.py	80% <ø> (ø)	⬆️
reframe/frontend/dependency.py	96.77% <ø> (ø)	⬆️
unittests/resources/settings.py	100% <ø> (ø)	⬆️
reframe/core/meta.py	100% <ø> (ø)	⬆️
reframe/core/exceptions.py	84.89% <ø> (+0.1%)	⬆️
reframe/core/systems.py	89.67% <ø> (ø)	⬆️
...ittests/resources/checks_unlisted/kbd_interrupt.py	100% <ø> (ø)	⬆️
... and 152 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd6d377...828a26a. Read the comment docs.

[vkarak]

I think that the unit test for the run-only tests case would pass even before the fix. The post_run is just commands to be inserted in the generated script. So, for sure, greetings.txt is going to be present in the stage directory regardless. The correct way to test is perhaps by manipulating the sourcesdir. You could set sourcesdir to None before run and then make sure that nothing was copied to the stage directory. Without the fix, this would fail, because it would run the hook after the copy to the stage directory.

[pep8speaks]

Hello @ekouts, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2020-03-10 10:03:24 UTC

[vkarak]

lgtm