-
Notifications
You must be signed in to change notification settings - Fork 117
[test] Fix CDO checks #1179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Fix CDO checks #1179
Conversation
|
Hello @omlins, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2020-02-19 08:32:03 UTC |
lucamar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @omlins
|
@omlins Can you please put in the description the internal issues that this one fixes? |
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be breaking the test on Tsa and also I'd like to know if the changes for Tsa before has broken the test on other systems.
|
@jenkins-cscs retry tsa |
|
@jenkins-cscs retry all |
1 similar comment
|
@jenkins-cscs retry all |
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
@jenkins-cscs retry none |
Codecov Report
@@ Coverage Diff @@
## master #1179 +/- ##
==========================================
+ Coverage 91.99% 92.02% +0.02%
==========================================
Files 81 81
Lines 11693 11736 +43
==========================================
+ Hits 10757 10800 +43
Misses 936 936
Continue to review full report at Codecov.
|
The CDO version installed on Daint/Dom is not the same as the one on Tsa/Arolla and they print a different message in case of success. This PR generalizes the sanity check to work with both CDO versions.