Skip to content

Conversation

@omlins
Copy link
Contributor

@omlins omlins commented Feb 18, 2020

The CDO version installed on Daint/Dom is not the same as the one on Tsa/Arolla and they print a different message in case of success. This PR generalizes the sanity check to work with both CDO versions.

@pep8speaks
Copy link

pep8speaks commented Feb 18, 2020

Hello @omlins, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2020-02-19 08:32:03 UTC

Copy link
Contributor

@lucamar lucamar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @omlins

@vkarak
Copy link
Contributor

vkarak commented Feb 18, 2020

@omlins Can you please put in the description the internal issues that this one fixes?

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be breaking the test on Tsa and also I'd like to know if the changes for Tsa before has broken the test on other systems.

@omlins
Copy link
Contributor Author

omlins commented Feb 18, 2020

@jenkins-cscs retry tsa

@omlins
Copy link
Contributor Author

omlins commented Feb 18, 2020

@jenkins-cscs retry all

1 similar comment
@omlins
Copy link
Contributor Author

omlins commented Feb 18, 2020

@jenkins-cscs retry all

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak
Copy link
Contributor

vkarak commented Feb 19, 2020

@jenkins-cscs retry none

@codecov-io
Copy link

codecov-io commented Feb 19, 2020

Codecov Report

Merging #1179 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1179      +/-   ##
==========================================
+ Coverage   91.99%   92.02%   +0.02%     
==========================================
  Files          81       81              
  Lines       11693    11736      +43     
==========================================
+ Hits        10757    10800      +43     
  Misses        936      936
Impacted Files Coverage Δ
unittests/test_utility.py 99.23% <100%> (+0.01%) ⬆️
reframe/frontend/cli.py 80.93% <100%> (+0.05%) ⬆️
reframe/utility/os_ext.py 91% <100%> (+0.72%) ⬆️
unittests/test_cli.py 93.69% <100%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3861207...7a72e38. Read the comment docs.

@vkarak vkarak merged commit 88ef937 into reframe-hpc:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants