[test] Fix misleading variant description in the affinity check #1200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can I test this patch? |
Codecov Report
@@ Coverage Diff @@
## master #1200 +/- ##
=======================================
Coverage 92.17% 92.17%
=======================================
Files 81 81
Lines 11999 11999
=======================================
Hits 11060 11060
Misses 939 939
Continue to review full report at Codecov.
|
rsarm
approved these changes
Feb 26, 2020
Contributor
|
ok to test |
teojgo
requested changes
Feb 26, 2020
Contributor
teojgo
left a comment
teojgo
left a comment
There was a problem hiding this comment.
@mand35 please change also the corresponding variant name in https://github.com/eth-cscs/reframe/blob/6b2dc404c7b27feaeca81f3585a6104202fe718c/cscs-checks/prgenv/affinity_check.py#L132
vkarak
changed the title
Contributor
Author
|
Thanks @teojgo for the hint. change applied. |
vkarak
approved these changes
Feb 27, 2020
teojgo
approved these changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.