[feat] Impose units in performance reference tuple #1223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix checks that don't contain units in performance reference tuples. * Add unit test. * Documentation fixes.
teojgo
changed the title
vkarak
requested changes
Mar 11, 2020
vkarak
requested changes
Mar 12, 2020
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
Just a minor comment still.
Contributor
|
@jenkins-cscs retry none |
Codecov Report
@@ Coverage Diff @@
## master #1223 +/- ##
=======================================
Coverage 91.92% 91.92%
=======================================
Files 84 84
Lines 12209 12209
=======================================
Hits 11223 11223
Misses 986 986
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix checks that don't contain units in performance reference tuples.
Add unit test.
Documentation fixes.
Fixes #1147