Skip to content

[bugfix] Make unit test for TERM signal handling more robust #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 12, 2020
Merged

[bugfix] Make unit test for TERM signal handling more robust #1227

merged 3 commits into from
Mar 12, 2020

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Mar 11, 2020

  • Explicitly call os.kill from a regression check.

Related to #1217

Simplify unittesting of TERM signal handling
ccaa108 
* Explicitly call `os.kill` from a regression check.
@teojgo teojgo added this to the ReFrame sprint 20.03 milestone Mar 11, 2020
@teojgo teojgo requested review from victorusu and vkarak March 11, 2020 16:12
@teojgo teojgo self-assigned this Mar 11, 2020
@codecov-io
Copy link

codecov-io commented Mar 11, 2020 •
edited
Loading

Codecov Report

Merging #1227 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1227      +/-   ##
==========================================
+ Coverage      92%   92.07%   +0.07%     
==========================================
  Files          83       84       +1     
  Lines       12166    12171       +5     
==========================================
+ Hits        11193    11207      +14     
+ Misses        973      964       -9
Impacted Files Coverage Δ
unittests/resources/checks_unlisted/selfkill.py 100% <100%> (ø)
unittests/test_policies.py 98.96% <100%> (+1.32%) ⬆️
reframe/frontend/executors/__init__.py 98.05% <0%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e90868...0730f66. Read the comment docs.

vkarak
vkarak requested changes Mar 11, 2020
View reviewed changes
vkarak
vkarak approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak changed the title [bugfix] Simplify unittesting of TERM signal handling [bugfix] Simplify unit testing of TERM signal handling Mar 12, 2020
@vkarak vkarak changed the title [bugfix] Simplify unit testing of TERM signal handling [bugfix] Make unit test for TERM signal handling more robust Mar 12, 2020
@vkarak vkarak merged commit a32e677 into reframe-hpc:master Mar 12, 2020
@teojgo teojgo deleted the bugfix/sigterm_unittest_runner branch May 12, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@victorusu victorusu Awaiting requested review from victorusu

Assignees

@teojgo teojgo

Labels

bugfix prio: normal

Projects

None yet

Milestone

ReFrame sprint 20.03

Development

Successfully merging this pull request may close these issues.

3 participants

@teojgo @codecov-io @vkarak