Skip to content

Conversation

@ekouts
Copy link
Contributor

@ekouts ekouts commented Mar 18, 2020

This is an example of the new expected output:

List of matched checks
======================
  * T0 (found in /path/to/reframe/unittests/resources/checks_unlisted/deps_complex.py)
      - description: T0
      - systems: *
      - environments: *
      - modules: 
      - task allocation: standard
      - dependencies:
      - tags: 
      - maintainers: 
  * T1 (found in /path/to/reframe/unittests/resources/checks_unlisted/deps_complex.py)
      - description: T1
      - systems: *
      - environments: *
      - modules: 
      - task allocation: standard
      - dependencies: T4, T5
      - tags: 
      - maintainers:
...

Fixes #1091

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the following output. We don't need such a detailed information.

List of matched checks
======================
  * T0 (found in /path/to/reframe/unittests/resources/checks_unlisted/deps_complex.py)
      - description: T0
      - systems: *
      - environments: *
      - modules: 
      - task allocation: standard
      - dependencies:  <-- just leave it empty 
      - tags: 
      - maintainers: 
  * T1 (found in /path/to/reframe/unittests/resources/checks_unlisted/deps_complex.py)
      - description: T1
      - systems: *
      - environments: *
      - modules: 
      - task allocation: standard
      - dependencies: T4, T5
      - tags: 
      - maintainers:
...

@vkarak
Copy link
Contributor

vkarak commented Mar 25, 2020

We could have another option for showing the full dependency tree, but that's a different issue.

@codecov-io
Copy link

codecov-io commented Mar 26, 2020

Codecov Report

Merging #1237 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1237   +/-   ##
=======================================
  Coverage   91.37%   91.37%           
=======================================
  Files          84       84           
  Lines       12398    12398           
=======================================
  Hits        11329    11329           
  Misses       1069     1069
Impacted Files Coverage Δ
reframe/frontend/cli.py 81.45% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fe7bec...f7395da. Read the comment docs.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak changed the title [feat] Print dependencies of a test in --list-detailed output [feat] Print test dependencies in output of --list-detailed Mar 26, 2020
@vkarak vkarak merged commit d769d5d into reframe-hpc:master Mar 26, 2020
@ekouts ekouts deleted the feat/list-dependencies branch March 27, 2020 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--list-detailed output does not mention test dependencies

3 participants