Skip to content

[bugfix] Do not update progress count when a test fails with status ERROR #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2020
Merged

[bugfix] Do not update progress count when a test fails with status ERROR #1247

merged 1 commit into from
Mar 30, 2020

Conversation

@ekouts
Copy link
Contributor

@ekouts ekouts commented Mar 30, 2020

This is a simple bug fix for the progress report. The testcases that print ERROR have already printed OK before so _progress_count should not be updated. The (x/total) message will also be omitted.

@ekouts ekouts added this to the ReFrame sprint 20.05 milestone Mar 30, 2020
@ekouts ekouts requested a review from vkarak March 30, 2020 14:25
@ekouts ekouts self-assigned this Mar 30, 2020
@codecov-io
Copy link

codecov-io commented Mar 30, 2020 •
edited
Loading

Codecov Report

Merging #1247 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1247   +/-   ##
=======================================
  Coverage   91.42%   91.42%           
=======================================
  Files          84       84           
  Lines       12401    12401           
=======================================
  Hits        11337    11337           
  Misses       1064     1064
Impacted Files Coverage Δ
reframe/frontend/printer.py 93.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17b9406...d79b57c. Read the comment docs.

vkarak
vkarak approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak changed the title [bugfix] Remove _progress_count update when a test fails with status ERROR [bugfix] Do not update progress count when a test fails with status ERROR Mar 30, 2020
@vkarak vkarak merged commit 2d42a61 into reframe-hpc:master Mar 30, 2020
@ekouts ekouts deleted the bugfix/progress_report branch March 31, 2020 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

Assignees

@ekouts ekouts

Labels

bugfix prio: normal

Projects

None yet

Milestone

ReFrame sprint 20.05

Development

Successfully merging this pull request may close these issues.

3 participants

@ekouts @codecov-io @vkarak